Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Branch-Type Parameter and rename serve to type #190

Closed
wants to merge 2 commits into from
Closed

Remove Branch-Type Parameter and rename serve to type #190

wants to merge 2 commits into from

Conversation

MaZderMind
Copy link

These are the callback-parameters when adding 4 video sources:

parameters=(3003, 1, 7)
parameters=(3004, 1, 8)
parameters=(3005, 1, 10)
parameters=(3006, 1, 10)

The second Parameter shows the GstSwitchServeStreamType served on that port:

  • 1 = GST_SERVE_VIDEO_STREAM
  • 2 = GST_SERVE_AUDIO_STREAM

The third Parameter shows the GstCaseType serving that port:

  • 7 = GST_CASE_BRANCH_VIDEO_A
  • 8 = GST_CASE_BRANCH_VIDEO_B
  • 10 = GST_CASE_BRANCH_PREVIEW

The latter information is not useful to the client at all and it is only valid until the GUI selects another Video as Source. Therefore I'd suggest to remove that extra Parameter.

From the View of a Client, ie. the GUI, Type is a better name for the Information that Parameter is carrying, so I renamed Serve to Type on the go.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.06% when pulling 0d2523c on MaZderMind:cleanup-preview-port-interface into 573d97a on timvideos:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.46%) to 98.52% when pulling ed12422 on MaZderMind:cleanup-preview-port-interface into 573d97a on timvideos:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.28%) to 97.79% when pulling ed12422 on MaZderMind:cleanup-preview-port-interface into 573d97a on timvideos:master.

@mithro
Copy link
Member

mithro commented Feb 1, 2015

How does the client current figure out which preview videos are active? (IE which preview is connected to channel a, b or the audio output?)

@MaZderMind
Copy link
Author

As far as I can see there are no methods/signals implemented for this atm, but as far as I can tell there was no such way even before my rewrites. I'll add a callback for that and open a PR.

@mithro
Copy link
Member

mithro commented Feb 1, 2015

Previously the UI would show red/blue borders around the selected videos.

@MaZderMind
Copy link
Author

I can't see this behaviour from Code in December. This Feature must have been gone before the start of 2015. I can't see any sign of that in the Code, neither.

Can it be that the UI just selected the Color itsself - without asking the API or waiting for a Callback-Signal?

@techman83
Copy link

It may have been just in UI, IIRC it didn't really relate to what was occurring in the server as the red borders never disappeared once you clicked the images.

@MaZderMind MaZderMind mentioned this pull request Feb 3, 2015
Closed
@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling ed12422 on MaZderMind:cleanup-preview-port-interface into 573d97a on timvideos:master.

@MaZderMind MaZderMind force-pushed the cleanup-preview-port-interface branch from ed12422 to 4ff7b96 Compare May 4, 2015 18:26
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.91% when pulling 4ff7b96 on MaZderMind:cleanup-preview-port-interface into 9ad792a on timvideos:master.

@mithro mithro closed this Mar 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cleanup server
Projects
None yet
Milestone
No milestone
5 participants
@MaZderMind @coveralls @mithro @techman83 @landscape-bot