Dbus API with Signals #184

MaZderMind · 2015-01-29T22:37:45Z

Re-Implement the Server-to-Client-Communication using DBus-Signals.
This allows using this Communication in Python and also provides a much cleaner interface.

This PR reconfigures the Server, the C-Client, the UI, the PTZ-Capture-Tool, and also the Python-API. It contains Unit- and Integration-Tests that ensures that the Signal-Handlers actually fire in the right Way.

fixes #172 by removing the concept of a role

landscape-bot · 2015-01-29T22:42:06Z

Repository health decreased by 0.51% when pulling a2ecdd5 on MaZderMind:dbus-api-signals into 47600c7 on timvideos:master.

8 new problems were found (including 2 errors and 5 code smells).
No problems were fixed.

mithro · 2015-01-29T23:25:28Z

python-api/gstswitch/controller.py

@@ -394,3 +415,39 @@ def parse_preview_ports(cls, res):
        for tupl in liststr:
            preview_ports.append(int(tupl[0]))
        return preview_ports
+
+    def on_preview_port_added(self, cb):
+        if not hasattr(cb, '__call__'):


┌──────────────────────────────────────────────────────────────────────────────────────────────────────────────┐ │ callable: (object) │ │ callable(object) -> bool │ │ │ │ Return whether the object is callable (i.e., some kind of function). │ │ Note that classes are callable, as are instances with a __call__() method. │ └──────────────────────────────────────────────────────────────────────────────────────────────────────────────┘

callable was not available from python3 to python 3.2 and 2to3 will probably change it back to an isinstance call, but to appreciate the future (it's back in python3.3), I'll change that :)

mithro · 2015-01-29T23:32:40Z

Can you check if this patch is pep8 and pylint clean?

mithro · 2015-01-29T23:34:13Z

Can you check and see if any of the landscape errors are relevant?

mithro · 2015-01-29T23:34:39Z

Generally looks pretty good - only some minor clean up issues.

MaZderMind · 2015-01-30T08:56:48Z

The things I did not comment directly on are fixed with these Commits. There are some PEP8-Warnings that I can't see a way to avoid them:

peter@spock ~/AAA-VOC/gst-switch/python-api $ make test
PYTHONWARNINGS=ignore
PYTHONPATH=:/home/peter/AAA-VOC/gst-switch/python-api
pylint --rcfile=.pylintrc_gstswitch gstswitch
************* Module gstswitch.controller
W:181,16: Used * or ** magic (star-args)
W:166,42: Unused argument 'sender_name' (unused-argument)
W:167,65: Unused argument 'user_data' (unused-argument)
W:166,55: Unused argument 'object_path' (unused-argument)
W:166,30: Unused argument 'connection' (unused-argument)
W:167,24: Unused argument 'interface_name' (unused-argument)
Makefile:6: recipe for target 'lint' failed
make: *** [lint] Error 4

landscape-bot · 2015-01-30T08:57:03Z

Repository health decreased by 0.70% when pulling 48c50e0 on MaZderMind:dbus-api-signals into 47600c7 on timvideos:master.

8 new problems were found (including 2 errors and 5 code smells).
No problems were fixed.

landscape-bot · 2015-01-30T09:32:21Z

Repository health increased by 0.19% when pulling bd64d19 on MaZderMind:dbus-api-signals into 47600c7 on timvideos:master.

3 new problems were found (including 2 errors and 0 code smells).
No problems were fixed.

landscape-bot · 2015-01-31T12:46:50Z

Repository health increased by 0.21% when pulling 7aa420a on MaZderMind:dbus-api-signals into d9ce0ac on timvideos:master.

3 new problems were found (including 2 errors and 0 code smells).
No problems were fixed.

coveralls · 2015-01-31T12:49:24Z

Coverage decreased (-1.27%) to 98.14% when pulling 7aa420a on MaZderMind:dbus-api-signals into d9ce0ac on timvideos:master.

landscape-bot · 2015-01-31T13:03:48Z

Repository health increased by 0.21% when pulling 0e1b2af on MaZderMind:dbus-api-signals into d9ce0ac on timvideos:master.

3 new problems were found (including 2 errors and 0 code smells).
No problems were fixed.

coveralls · 2015-01-31T13:04:03Z

Coverage decreased (-1.27%) to 98.14% when pulling 0e1b2af on MaZderMind:dbus-api-signals into d9ce0ac on timvideos:master.

mithro · 2015-01-31T13:45:42Z

python-api/gstswitch/controller.py

+            bus_name='us.timvideos.gstswitch.SwitchController',
+            object_path="/us/timvideos/gstswitch/SwitchController",
+            default_interface=("us.timvideos.gstswitch."
+                               "SwitchControllerInterface")
    ):


This would be better wrapped as

+ default_interface=( + "us.timvideos.gstswitch.SwitchControllerInterface")

IT is not really a source-File and the suggestions are … not so good

coveralls · 2015-01-31T15:33:42Z

Coverage decreased (-1.53%) to 97.79% when pulling d23a94d on MaZderMind:dbus-api-signals into 912d5fa on timvideos:master.

coveralls · 2015-01-31T15:33:43Z

Coverage decreased (-1.25%) to 98.06% when pulling d23a94d on MaZderMind:dbus-api-signals into 912d5fa on timvideos:master.

coveralls · 2015-01-31T18:48:21Z

Coverage decreased (-1.25%) to 98.06% when pulling f3aca36 on MaZderMind:dbus-api-signals into 912d5fa on timvideos:master.

coveralls · 2015-01-31T18:48:21Z

Coverage decreased (-1.25%) to 98.06% when pulling f3aca36 on MaZderMind:dbus-api-signals into 912d5fa on timvideos:master.

mithro · 2015-02-01T07:01:39Z

tools/gstswitchcontrollerintrospection.c

@@ -0,0 +1,115 @@
+/* GstSwitch


This copyright header is wrong. It should be;

/* gst-switch -*- c -*- * Copyright (C) 2015 Peter XXXX <xxx@xxxxx> * * This file is part of gst-switch. * * gst-switch is free software: you can redistribute it and/or modify it under * the terms of the GNU General Public License as published by the Free * Software Foundation, either version 3 of the License, or (at your option) * any later version. * * This program is distributed in the hope that it will be useful, but WITHOUT * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for * more details. * * You should have received a copy of the GNU General Public License along with * this program. If not, see <http://www.gnu.org/licenses/>. */

Change the DBus API to be more inline with how DBus should be used.

mithro reviewed Jan 29, 2015
View reviewed changes

mithro added server python-api labels Jan 29, 2015

mithro added the enhancement label Jan 31, 2015

MaZderMind force-pushed the dbus-api-signals branch from bd64d19 to 7aa420a Compare January 31, 2015 12:43

mithro reviewed Jan 31, 2015
View reviewed changes

MaZderMind added 13 commits January 31, 2015 15:48

USe pythons old-new callable()

32700cf

Reorder Imports in Test

2a1c2ae

Move segfault-test into Helpers

f11550f

Quit Mainloop after both Sources have been spawned

efcdc83

Extract introspection_xml into external Compilation-Unit

2d7e169

Fix PEP8 Errors

dca308f

Fix Pylint-Errors

305fed1

Fix typo

dde6231

Fix some more PEP8 Errors

8e0af98

Rename the info.duzy Identifiers to us.timvideos

41b70d3

Fix Intentation & make style Issues

5de58a5

Ignore gstswitchcontrollerintrospection.c when checking indentation

5983d18

IT is not really a source-File and the suggestions are … not so good

Fix Python3 Compatibility

d23a94d

MaZderMind force-pushed the dbus-api-signals branch from 0e1b2af to d23a94d Compare January 31, 2015 15:26

MaZderMind added 8 commits January 31, 2015 19:04

Use callable

fd9dc9f

Nicer String-Wrapping

b8770dc

Explain pylint Ignores and reduce their Range to one Line

82429db

Document Callbacks

5225478

Fix Typo

39212b8

Re-Enable Threading for the DBus-Server

a96157c

Move assert_no_segfault into the Server-Class

fbd88d2

Disable Indent-Checking inside the introspection-File only

f3aca36

mithro reviewed Feb 1, 2015
View reviewed changes

mithro added a commit that referenced this pull request Feb 1, 2015

Merge pull request #184 from MaZderMind/dbus-api-signals

0109013

Change the DBus API to be more inline with how DBus should be used.

mithro merged commit 0109013 into timvideos:master Feb 1, 2015

MaZderMind deleted the dbus-api-signals branch February 1, 2015 09:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dbus API with Signals #184

Dbus API with Signals #184

MaZderMind commented Jan 29, 2015

landscape-bot commented Jan 29, 2015

mithro Jan 29, 2015

MaZderMind Jan 30, 2015

mithro commented Jan 29, 2015

mithro commented Jan 29, 2015

mithro commented Jan 29, 2015

MaZderMind commented Jan 30, 2015

landscape-bot commented Jan 30, 2015

landscape-bot commented Jan 30, 2015

landscape-bot commented Jan 31, 2015

coveralls commented Jan 31, 2015

landscape-bot commented Jan 31, 2015

coveralls commented Jan 31, 2015

mithro Jan 31, 2015

MaZderMind Jan 31, 2015

coveralls commented Jan 31, 2015

coveralls commented Jan 31, 2015

coveralls commented Jan 31, 2015

coveralls commented Jan 31, 2015

mithro Feb 1, 2015

Dbus API with Signals #184

Dbus API with Signals #184

Conversation

MaZderMind commented Jan 29, 2015

landscape-bot commented Jan 29, 2015

mithro Jan 29, 2015

Choose a reason for hiding this comment

MaZderMind Jan 30, 2015

Choose a reason for hiding this comment

mithro commented Jan 29, 2015

mithro commented Jan 29, 2015

mithro commented Jan 29, 2015

MaZderMind commented Jan 30, 2015

landscape-bot commented Jan 30, 2015

landscape-bot commented Jan 30, 2015

landscape-bot commented Jan 31, 2015

coveralls commented Jan 31, 2015

landscape-bot commented Jan 31, 2015

coveralls commented Jan 31, 2015

mithro Jan 31, 2015

Choose a reason for hiding this comment

MaZderMind Jan 31, 2015

Choose a reason for hiding this comment

coveralls commented Jan 31, 2015

coveralls commented Jan 31, 2015

coveralls commented Jan 31, 2015

coveralls commented Jan 31, 2015

mithro Feb 1, 2015

Choose a reason for hiding this comment