Multiple Bootstrap related UI tweakings #94
Conversation
- Started working on getting some more info about the current talk in the navbar. - Removed HTML injection issues from the event feeds, making them all use the "generated" tag instead. - Disallowed HTML in the event feed JSON output generator. - Navbar is now white. - Add LCA logo. - Remove padding between elements.
| @@ -177,7 +177,7 @@ def main(argv): | |||
| else: | |||
| sys.stderr.write('Event %r does not have a End time or Duration, dropped.\n' % item['Title']) | |||
| continue | |||
| if 'url' in item: | |||
| if 'URL' in item: | |||
There was a problem hiding this comment.
Case change?
Should this be if 'URL' in item or 'url' in item or something?
Maybe just lower all the keys?
There was a problem hiding this comment.
It's tracking the current version of Zookeepr, which has some major discrepancies in the keys.
There's multiple issues with the Zookeepr feeds which I've reported in the past:
- Change "Room Name" parameter in schedule JSON output so that it does not contain spaces zookeepr/zookeepr#269
- Start times in schedule JSON are not ISO8601 (defacto JSON date format), and are expressed in localtime with no timezone information zookeepr/zookeepr#270
There's also no schema for the JSON feed which has been broken before without warning. In part this is because there is no schema for this data.
Maybe poking @iseppi into 1) having a published schema for Zookeepr and 2) actually sticking to it would be the best way forward from here.
There was a problem hiding this comment.
Lets just work around this it for now. This tool is already doing lots of other horrible munding.
Just lower all the keys.
|
Still two open things here;
|
|
There's more than case sensitivity that is an issue for the Zookeepr schema -- unfortunately is not that simple. The webchat blocks navigation if logged in, but not if it is not logged in. The formatting things are replaced with a much saner implementation in JavaScript directly, and now calls |
Lets worry about getting Zookeepr fixed another time.
We trust data from zookeepr and we generate ourselves. We also have no "user data" to steal, so injection isn't really an issue. I'm going to merge this, but we should probably look at rolling back this bit. |
Multiple Bootstrap related UI tweakings
navbar.
the "generated" tag instead.