Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 8e190bf6a13f
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 0bccb341c41e
Choose a head ref
  • 3 commits
  • 3 files changed
  • 3 contributors

Commits on Apr 18, 2013

  1. Copy the full SHA
    a835a2f View commit details
    Browse the repository at this point in the history
  2. assert: put info in err.message, not err.name

    4716dc6 made assert.equal() and related functions work better by
    generating a better toString() from the expected, actual, and operator
    values passed to fail(). Unfortunately, this was accomplished by putting
    the generated message into the error's `name` property. When you passed
    in a custom error message, the error would put the custom error into
    `name` *and* `message`, resulting in helpful string representations like
    "AssertionError: Oh no: Oh no".
    
    This commit resolves that issue by storing the generated message in the
    `message` property while leaving the error's name alone and adding
    a regression test so that this doesn't pop back up later.
    
    Closes #5292.
    hackedy authored and isaacs committed Apr 18, 2013
    Copy the full SHA
    6101eb1 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    0bccb34 View commit details
    Browse the repository at this point in the history