Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 4ffa943c3f25
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 6cd7fd7d243f
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Aug 12, 2013

  1. cares_wrap: don't set oncomplete property from c++

    Don't set the oncomplete property in src/cares_wrap.cc, we can do it
    just as easily in lib/dns.js.
    
    Switch two closures to the 'function with _this_ object' model. Makes
    it impossible for an overzealous closure to capture too much context
    and accidentally hold on to too much memory.
    bnoordhuis committed Aug 12, 2013
    Copy the full SHA
    6cd7fd7 View commit details
    Browse the repository at this point in the history