no longer copy subset index

shogun-toolbox · May 6, 2012 · 8264e5c · 8264e5c
1 parent 3bc5f3e
commit 8264e5c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/src/shogun/features/Subset.cpp b/src/shogun/features/Subset.cpp
@@ -22,11 +22,7 @@ CSubset::CSubset(SGVector<index_t> subset_idx)
 {
 	init();
 
-	/* copy indices. TODO this is not needed once there is ref-counting for
-	 * SGVectors */
-	m_subset_idx=SGVector<index_t>(subset_idx.vlen);
-	memcpy(m_subset_idx.vector, subset_idx.vector,
-			subset_idx.vlen*sizeof(index_t));
+	m_subset_idx=subset_idx;
 }
 
 CSubset::~CSubset() {

diff --git a/src/shogun/features/Subset.h b/src/shogun/features/Subset.h
@@ -17,10 +17,7 @@
 namespace shogun
 {
 
-/** @brief Wrapper class for an index subset which is used by SubsetStack.
- * Currently, all index sets that are given to a CSubset instance are COPIED.
- * This is bad because these should be re-usable, however, until there is no
- * reference counting for SGVectors, this wont be possible. TODO */
+/** @brief Wrapper class for an index subset which is used by SubsetStack. */
 class CSubset: public CSGObject
 {
 	friend class CSubsetStack;
@@ -45,6 +42,7 @@ class CSubset: public CSGObject
 
 	/** @return name of the SGSerializable */
 	inline const char* get_name() const { return "Subset"; }
+
 private:
 	void init();