Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 94f4143

Browse files
committedMar 7, 2012
Fix tag attach/detach for non-admin users
1 parent ecf22ae commit 94f4143

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed
 

‎api/soap/mc_tag_api.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -149,13 +149,13 @@ function mci_tag_set_for_issue ( $p_issue_id, $p_tags, $p_user_id ) {
149149

150150
foreach ( $t_tag_ids_to_detach as $t_tag_id ) {
151151
if ( access_has_bug_level ( config_get('tag_detach_threshold'), $p_issue_id, $p_user_id ) ) {
152-
tag_bug_detach( $t_tag_id, $p_issue_id, true);
152+
tag_bug_detach( $t_tag_id, $p_issue_id, $p_user_id);
153153
}
154154
}
155155

156156
foreach ( $t_tag_ids_to_attach as $t_tag_id ) {
157157
if ( access_has_bug_level ( config_get('tag_attach_threshold'), $p_issue_id, $p_user_id ) ) {
158-
tag_bug_attach( $t_tag_id, $p_issue_id, true);
158+
tag_bug_attach( $t_tag_id, $p_issue_id, $p_user_id);
159159
}
160160
}
161161
}

2 commit comments

Comments
 (2)

atrol commented on Mar 7, 2012

@atrol
Member

Really?
I didn't have a deeper look but have a look at the signature of the function tag_bug_detach, user_id is the fourth parameter.
function tag_bug_detach( $p_tag_id, $p_bug_id, $p_add_history = true, $p_user_id = null )

rombert commented on Mar 7, 2012

@rombert
MemberAuthor

@atrol You're obviously right, thanks.

Please sign in to comment.