Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Commit

Permalink
test-child-process-spawn-loop: make it pass on Windows.
Browse files Browse the repository at this point in the history
It wasn't waiting for the child process' stderr to close, so not an
assertion was made *before* all the data that the child process sent
was received by node.
  • Loading branch information
piscisaureus committed Jun 13, 2012
1 parent e733dc3 commit 74c8041
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/pummel/test-child-process-spawn-loop.js
Expand Up @@ -46,7 +46,7 @@ function doSpawn(i) {
console.log('stderr: ' + chunk);
});

child.on('exit', function() {
child.on('close', function() {
// + 1 for \n or + 2 for \r\n on Windows
assert.equal(SIZE + (is_windows ? 2 : 1), count);
if (i < N) {
Expand Down

0 comments on commit 74c8041

Please sign in to comment.