This repository has been archived by the owner on May 7, 2021. It is now read-only.
Add support for specifying services for getPublic() and getCharts(). #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // TODO: Add some sort of helper function so we aren't repeating the same | ||
| // 6 lines of code with a single string changed for every endpoint. | ||
| // At the moment the duplicated code is just in are getPublic() | ||
| // and getCharts(), but it'll be required for every endpoint added. |
There was a problem hiding this comment.
I feel like TODOs should be in the issue tracker :P
rummik
added a commit
that referenced
this pull request
Apr 2, 2014
Add support for specifying services for getPublic() and getCharts().
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #51.