Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new method to retrieve encounter role objects by name #378

Closed
wants to merge 1 commit into from

Conversation

surangak
Copy link
Member

@surangak surangak commented Aug 5, 2013

No description provided.

@wluyima
Copy link
Member

wluyima commented Aug 28, 2013

Can you please include the ticket url in the summary of this pull request?

@wluyima
Copy link
Member

wluyima commented Aug 29, 2013

What is the ticket number for this ticket suranga?

@surangak
Copy link
Member Author

Sorry @wluyima , I had missed your previous message. I've updated it now :-)

@wluyima
Copy link
Member

wluyima commented Aug 29, 2013

Thanks

@wluyima
Copy link
Member

wluyima commented Aug 29, 2013

But i already see this PR #389 with the same ticket number, is there a mistake or something?

@surangak
Copy link
Member Author

Hi,

Ok, I see the problem now. This was the pull I submitted BEFORE the detailed discussion we had on the mailing list on this topic. After I got more feedback on the topic, I switched to a different pull request
(pull #389)
So yes, this pull is obsolete, and unnecessary. Please ignore it in favor of pull no. 389 :-)

Sorry for the other caused in this matter :-)

@wluyima
Copy link
Member

wluyima commented Aug 29, 2013

I have closed this assuming the code is dead

@wluyima wluyima closed this Aug 29, 2013
@dkayiwa dkayiwa reopened this Nov 22, 2013
@dkayiwa
Copy link
Member

dkayiwa commented Nov 22, 2013

Merged at: 09e6105

@dkayiwa dkayiwa closed this Nov 22, 2013
RandilaP pushed a commit to RandilaP/openmrs-core that referenced this pull request Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants