Skip to content

Commit

Permalink
Revert incorrect change to function definition
Browse files Browse the repository at this point in the history
The parameters for function excel_format_custom_field() were unduly
changed, preventing proper exporting of custom field data to Excel
(custom fields would be displayed as '@@'). This is a regression from
a39a948. Thanks to Roland Becker for
catching this.

This commit also fixes an incorrect comment in the function header for
excel_format_plugin_column_value().

Affects #13728
  • Loading branch information
dregad committed Feb 28, 2012
1 parent 6e1717a commit 3f91f58
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions core/excel_api.php
Expand Up @@ -482,7 +482,7 @@ function excel_format_additional_information( $p_bug ) {
* @param $p_custom_field The custom field name (without 'custom_' prefix).
* @returns The custom field value.
*/
function excel_format_custom_field( $p_bug ) {
function excel_format_custom_field( $p_issue_id, $p_project_id, $p_custom_field ) {
$t_field_id = custom_field_get_id_from_name( $p_custom_field );

if( $t_field_id === false ) {
Expand All @@ -502,7 +502,7 @@ function excel_format_custom_field( $p_bug ) {
* Gets the formatted value for the specified plugin column value.
* @param $p_custom_field The plugin column name.
* @param $p_bug The bug to print the column for (needed for the display function of the plugin column).
* @returns The custom field value.
* @returns The plugin column value.
*/
function excel_format_plugin_column_value( $p_column, $p_bug ) {
$t_plugin_columns = columns_get_plugin_columns();
Expand Down

0 comments on commit 3f91f58

Please sign in to comment.