Skip to content

Commit 3f91f58

Browse files
committedFeb 28, 2012
Revert incorrect change to function definition
The parameters for function excel_format_custom_field() were unduly changed, preventing proper exporting of custom field data to Excel (custom fields would be displayed as '@@'). This is a regression from a39a948. Thanks to Roland Becker for catching this. This commit also fixes an incorrect comment in the function header for excel_format_plugin_column_value(). Affects #13728
1 parent 6e1717a commit 3f91f58

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed
 

‎core/excel_api.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -482,7 +482,7 @@ function excel_format_additional_information( $p_bug ) {
482482
* @param $p_custom_field The custom field name (without 'custom_' prefix).
483483
* @returns The custom field value.
484484
*/
485-
function excel_format_custom_field( $p_bug ) {
485+
function excel_format_custom_field( $p_issue_id, $p_project_id, $p_custom_field ) {
486486
$t_field_id = custom_field_get_id_from_name( $p_custom_field );
487487

488488
if( $t_field_id === false ) {
@@ -502,7 +502,7 @@ function excel_format_custom_field( $p_bug ) {
502502
* Gets the formatted value for the specified plugin column value.
503503
* @param $p_custom_field The plugin column name.
504504
* @param $p_bug The bug to print the column for (needed for the display function of the plugin column).
505-
* @returns The custom field value.
505+
* @returns The plugin column value.
506506
*/
507507
function excel_format_plugin_column_value( $p_column, $p_bug ) {
508508
$t_plugin_columns = columns_get_plugin_columns();

0 commit comments

Comments
 (0)
Please sign in to comment.