[Truffle] Basic implementation of Kernel#system.

jruby · Jan 6, 2015 · 057cde9 · nirvdrum · Jan 6, 2015 · 057cde9
1 parent e45e0e4
commit 057cde9
Showing 2 changed files with 24 additions and 8 deletions.
diff --git a/core/src/main/java/org/jruby/truffle/nodes/core/KernelNodes.java b/core/src/main/java/org/jruby/truffle/nodes/core/KernelNodes.java
@@ -50,10 +50,7 @@
 import java.io.IOException;
 import java.io.PrintStream;
 import java.math.BigInteger;
-import java.util.Arrays;
-import java.util.Collection;
-import java.util.List;
-import java.util.Map;
+import java.util.*;
 
 @CoreClass(name = "Kernel")
 public abstract class KernelNodes {
@@ -1949,7 +1946,7 @@ public RubyString sprintf(Object[] args) {
         }
     }
 
-    @CoreMethod(names = "system", isModuleFunction = true, argumentsAsArray = true)
+    @CoreMethod(names = "system", isModuleFunction = true, needsSelf = false, required = 1)
     public abstract static class SystemNode extends CoreMethodNode {
 
         public SystemNode(RubyContext context, SourceSection sourceSection) {
@@ -1961,10 +1958,28 @@ public SystemNode(SystemNode prev) {
         }
 
         @Specialization
-        public Object fork(Object[] args) {
+        public boolean system(RubyString command) {
             notDesignedForCompilation();
-            getContext().getWarnings().warn("Kernel#system not implemented - defined to satisfy some metaprogramming in RubySpec");
-            return getContext().getCoreLibrary().getNilObject();
+
+            // TOOD(CS 5-JAN-15): very simplistic implementation
+
+            final RubyHash env = getContext().getCoreLibrary().getENV();
+
+            final List<String> envp = new ArrayList<>();
+
+            // TODO(CS): cast
+            for (KeyValue keyValue : HashOperations.verySlowToKeyValues(env)) {
+                envp.add(keyValue.getKey().toString() + "=" + keyValue.getValue().toString());
+            }
+
+            // We need to run via bash to get the variable and other expansion we expect
+            try {
+                Runtime.getRuntime().exec(new String[]{"bash", "-c", command.toString()}, envp.toArray(new String[envp.size()]));
+            } catch (IOException e) {
+                throw new RuntimeException(e);
+            }
+
+            return true;
         }
 
     }

diff --git a/core/src/main/java/org/jruby/truffle/nodes/core/SystemNode.java b/core/src/main/java/org/jruby/truffle/nodes/core/SystemNode.java
@@ -81,4 +81,5 @@ public Object execute(VirtualFrame frame) {
 
         return context.makeString(resultBuilder.toString());
     }
+
 }
Original file line number	Diff line number	Diff line change
		@@ -81,4 +81,5 @@ public Object execute(VirtualFrame frame) {

		return context.makeString(resultBuilder.toString());
		}

		}