Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d3df63c6026b
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ab3ec4927efa
Choose a head ref
  • 2 commits
  • 29 files changed
  • 1 contributor

Commits on Oct 1, 2014

  1. [Truffle] Restore struct specs tags.

    @chrisseaton
    chrisseaton committed Oct 1, 2014
    Copy the full SHA
    4a2d5ad View commit details

  2. [Truffle] Tag failing String#dup spec.

    @chrisseaton
    chrisseaton committed Oct 1, 2014
    Copy the full SHA
    ab3ec49 View commit details
Showing with 91 additions and 0 deletions.
  1. +1 −0 spec/truffle/tags/core/string/dup_tags.txt
  2. +4 −0 spec/truffle/tags/core/struct/each_pair_tags.txt
  3. +4 −0 spec/truffle/tags/core/struct/each_tags.txt
  4. +6 −0 spec/truffle/tags/core/struct/element_reference_tags.txt
  5. +2 −0 spec/truffle/tags/core/struct/element_set_tags.txt
  6. +5 −0 spec/truffle/tags/core/struct/eql_tags.txt
  7. +4 −0 spec/truffle/tags/core/struct/equal_value_tags.txt
  8. +5 −0 spec/truffle/tags/core/struct/hash_tags.txt
  9. +4 −0 spec/truffle/tags/core/struct/initialize_tags.txt
  10. +2 −0 spec/truffle/tags/core/struct/inspect_tags.txt
  11. +2 −0 spec/truffle/tags/core/struct/instance_variables_tags.txt
  12. +2 −0 spec/truffle/tags/core/struct/length_tags.txt
  13. +2 −0 spec/truffle/tags/core/struct/members_tags.txt
  14. +15 −0 spec/truffle/tags/core/struct/new_tags.txt
  15. +5 −0 spec/truffle/tags/core/struct/select_tags.txt
  16. +2 −0 spec/truffle/tags/core/struct/size_tags.txt
  17. +6 −0 spec/truffle/tags/core/struct/struct_tags.txt
  18. +2 −0 spec/truffle/tags/core/struct/tms/cstime_tags.txt
  19. +2 −0 spec/truffle/tags/core/struct/tms/cutime_tags.txt
  20. +1 −0 spec/truffle/tags/core/struct/tms/element_reference_tags.txt
  21. +1 −0 spec/truffle/tags/core/struct/tms/members_tags.txt
  22. +1 −0 spec/truffle/tags/core/struct/tms/new_tags.txt
  23. +2 −0 spec/truffle/tags/core/struct/tms/stime_tags.txt
  24. +2 −0 spec/truffle/tags/core/struct/tms/utime_tags.txt
  25. +2 −0 spec/truffle/tags/core/struct/to_a_tags.txt
  26. +2 −0 spec/truffle/tags/core/struct/to_h_tags.txt
  27. +2 −0 spec/truffle/tags/core/struct/to_s_tags.txt
  28. +2 −0 spec/truffle/tags/core/struct/values_at_tags.txt
  29. +1 −0 spec/truffle/tags/core/struct/values_tags.txt
1 change: 1 addition & 0 deletions spec/truffle/tags/core/string/dup_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
fails:String#dup calls #initialize_copy on the new instance
fails:String#dup copies instance variables
fails:String#dup does not modify the original string when changing dupped string
fails:String#dup does not copy constants defined in the singleton class
4 changes: 4 additions & 0 deletions spec/truffle/tags/core/struct/each_pair_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
fails:Struct#each_pair passes each key value pair to the given block
fails:Struct#each_pair returns self if passed a block
fails:Struct#each_pair returns an Enumerator if not passed a block
fails:Struct#each_pair does not override the instance accessor method
4 changes: 4 additions & 0 deletions spec/truffle/tags/core/struct/each_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
fails:Struct#each passes each value to the given block
fails:Struct#each returns self if passed a block
fails:Struct#each returns an Enumerator if not passed a block
fails:Struct#each does not override the instance accessor method
6 changes: 6 additions & 0 deletions spec/truffle/tags/core/struct/element_reference_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
fails:Struct[] is a synonym for new
fails:Struct#[] returns the attribute referenced
fails:Struct#[] fails when it does not know about the requested attribute
fails:Struct#[] fails if passed too many arguments
fails:Struct#[] fails if not passed a string, symbol, or integer
fails:Struct#[] returns attribute names that contain hyphens
2 changes: 2 additions & 0 deletions spec/truffle/tags/core/struct/element_set_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fails:Struct#[]= assigns the passed value
fails:Struct#[]= fails when trying to assign attributes which don't exist
5 changes: 5 additions & 0 deletions spec/truffle/tags/core/struct/eql_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
fails:Struct#eql? returns true if the other is the same object
fails:Struct#eql? returns true if the other has all the same fields
fails:Struct#eql? returns false if the other is a different object or has different fields
fails:Struct#eql? handles recursive structures by returning false if a difference can be found
fails:Struct#eql? returns false if any corresponding elements are not #eql?
4 changes: 4 additions & 0 deletions spec/truffle/tags/core/struct/equal_value_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
fails:Struct#== returns true if the other is the same object
fails:Struct#== returns true if the other has all the same fields
fails:Struct#== returns false if the other is a different object or has different fields
fails:Struct#== handles recursive structures by returning false if a difference can be found
5 changes: 5 additions & 0 deletions spec/truffle/tags/core/struct/hash_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
fails:Struct#hash returns the same fixnum for structs with the same content
fails:Struct#hash returns the same value if structs are #eql?
fails:Struct#hash allows for overriding methods in an included module
fails:Struct#hash returns the same hash for recursive structs
fails:Struct#hash does not override the instance accessor method
4 changes: 4 additions & 0 deletions spec/truffle/tags/core/struct/initialize_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
fails:Struct#initialize is private
fails:Struct#initialize does nothing when passed a set of fields equal to self
fails:Struct#initialize explicitly sets instance variables to nil when args not provided to initialize
fails:Struct#initialize can be overriden
2 changes: 2 additions & 0 deletions spec/truffle/tags/core/struct/inspect_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fails:Struct#inspect returns a string representation of some kind
fails:Struct#inspect returns a string representation without the class name for anonymous structs
2 changes: 2 additions & 0 deletions spec/truffle/tags/core/struct/instance_variables_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fails:Struct#instance_variables returns an empty array if only attributes are defined
fails:Struct#instance_variables returns an array with one name if an instance variable is added
2 changes: 2 additions & 0 deletions spec/truffle/tags/core/struct/length_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fails:Struct#length returns the number of attributes
fails:Struct#length does not override the instance accessor method
2 changes: 2 additions & 0 deletions spec/truffle/tags/core/struct/members_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fails:Struct#members returns an array of attribute names
fails:Struct#members does not override the instance accessor method
15 changes: 15 additions & 0 deletions spec/truffle/tags/core/struct/new_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
fails:Struct.new creates a constant in Struct namespace with string as first argument
fails:Struct.new overwrites previously defined constants with string as first argument
fails:Struct.new calls to_str on its first argument (constant name)
fails:Struct.new creates a new anonymous class with nil first argument
fails:Struct.new creates a new anonymous class with symbol arguments
fails:Struct.new does not create a constant with symbol as first argument
fails:Struct.new fails with invalid constant name as first argument
fails:Struct.new raises a TypeError if object doesn't respond to to_sym
fails:Struct.new raises a TypeError if object is not a Symbol
fails:Struct.new processes passed block with instance_eval
fails:Struct.new creates a constant in subclass' namespace
fails:Struct.new creates an instance
fails:Struct.new creates reader methods
fails:Struct.new creates writer methods
fails:Struct.new fails with too many arguments
5 changes: 5 additions & 0 deletions spec/truffle/tags/core/struct/select_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
fails:Struct#select raises an ArgumentError if given any non-block arguments
fails:Struct#select returns a new array of elements for which block is true
fails:Struct#select returns an instance of Array
fails:Struct#select does not override the instance accessor method
fails:Struct#select without block returns an instance of Enumerator
2 changes: 2 additions & 0 deletions spec/truffle/tags/core/struct/size_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fails:Struct#size is a synonym for length
fails:Struct#size does not override the instance accessor method
6 changes: 6 additions & 0 deletions spec/truffle/tags/core/struct/struct_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
fails:Struct includes Enumerable
fails:Struct anonymous class instance methods includes Enumerable
fails:Struct anonymous class instance methods reader method should be a synonym for []
fails:Struct anonymous class instance methods reader method should not interfere with undefined methods
fails:Struct anonymous class instance methods writer method be a synonym for []=
fails:Struct subclasses can be subclassed
2 changes: 2 additions & 0 deletions spec/truffle/tags/core/struct/tms/cstime_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fails:Struct::Tms#cstime needs to be reviewed for spec completeness
fails:Struct::Tms#cstime= needs to be reviewed for spec completeness
2 changes: 2 additions & 0 deletions spec/truffle/tags/core/struct/tms/cutime_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fails:Struct::Tms#cutime needs to be reviewed for spec completeness
fails:Struct::Tms#cutime= needs to be reviewed for spec completeness
1 change: 1 addition & 0 deletions spec/truffle/tags/core/struct/tms/element_reference_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
fails:Struct::Tms.[] needs to be reviewed for spec completeness
1 change: 1 addition & 0 deletions spec/truffle/tags/core/struct/tms/members_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
fails:Struct::Tms.members needs to be reviewed for spec completeness
1 change: 1 addition & 0 deletions spec/truffle/tags/core/struct/tms/new_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
fails:Struct::Tms.new needs to be reviewed for spec completeness
2 changes: 2 additions & 0 deletions spec/truffle/tags/core/struct/tms/stime_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fails:Struct::Tms#stime needs to be reviewed for spec completeness
fails:Struct::Tms#stime= needs to be reviewed for spec completeness
2 changes: 2 additions & 0 deletions spec/truffle/tags/core/struct/tms/utime_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fails:Struct::Tms#utime needs to be reviewed for spec completeness
fails:Struct::Tms#utime= needs to be reviewed for spec completeness
2 changes: 2 additions & 0 deletions spec/truffle/tags/core/struct/to_a_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fails:Struct#to_a returns the values for this instance as an array
fails:Struct#to_a does not override the instance accessor method
2 changes: 2 additions & 0 deletions spec/truffle/tags/core/struct/to_h_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fails:Struct#to_h returns a Hash with members as keys
fails:Struct#to_h returns a Hash that is independent from the struct
2 changes: 2 additions & 0 deletions spec/truffle/tags/core/struct/to_s_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fails:Struct#to_s is a synonym for inspect
fails:Struct#to_s returns a string representation without the class name for anonymous structs
2 changes: 2 additions & 0 deletions spec/truffle/tags/core/struct/values_at_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fails:Struct#values_at returns an array of values
fails:Struct#values_at fails when passed unsupported types
1 change: 1 addition & 0 deletions spec/truffle/tags/core/struct/values_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
fails:Struct#values is a synonym for to_a