Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: bfd16de12502
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: c3aae9cf9574
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Mar 22, 2013

  1. stream: Fix stall in Transform under very specific conditions 

    The stall is exposed in the test, though the test itself asserts before
it stalls.

The test is constructed to replicate the stalling state of a complex
Passthrough usecase since I was not able to reliable trigger the stall.

Some of the preconditions for triggering the stall are:
  * rs.length >= rs.highWaterMark
  * !rs.needReadable
  * _transform() handler that can return empty transforms
  * multiple sync write() calls

Combined this can trigger a case where rs.reading is not cleared when
further progress requires this. The fix is to always clear rs.reading.
    @kanongil @isaacs
    kanongil authored and isaacs committed Mar 22, 2013
    Copy the full SHA
    c3aae9c View commit details
    Browse the repository at this point in the history