Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 159da758e4f5
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: bf08ac462e2c
Choose a head ref
  • 3 commits
  • 12 files changed
  • 1 contributor

Commits on Jan 21, 2014

  1. async_wrap/timers: remove Add/RemoveAsyncListener 

    The ability to add/remove an AsyncListener to an object after its
creation was an artifact of trying to get AL working with the domain
module. Now that is no longer necessary and other features are going to
be implemented that would be affected by this functionality. So the code
will be removed for now to simplify the implementation process.

In the future this code will likely be reintroduced, but after some
other more important matters have been addressed.

None of this functionality was documented, as is was meant specifically
for domain specific implementation work arounds.

Signed-off-by: Timothy J Fontaine <tjfontaine@gmail.com>
    @trevnorris
    trevnorris committed Jan 21, 2014
    Copy the full SHA
    63ccfc3 View commit details
    Browse the repository at this point in the history

  2. node: ensure same AL inst only runs once 

    It was possible that the same AL instance was run twice if it were both
attached to the currentContext then again added to the new asyncQueue
generated for the new stack.

Signed-off-by: Timothy J Fontaine <tjfontaine@gmail.com>
    @trevnorris
    trevnorris committed Jan 21, 2014
    Copy the full SHA
    60fcc11 View commit details
    Browse the repository at this point in the history

  3. node: compare AsyncListener instances, not uid's 

    Now that process.createAsyncListener() returns a unique object instance
it is no longer necessary to compare the uid's of the objects.

Signed-off-by: Timothy J Fontaine <tjfontaine@gmail.com>
    @trevnorris
    trevnorris committed Jan 21, 2014
    Copy the full SHA
    bf08ac4 View commit details
    Browse the repository at this point in the history