Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mantisbt/mantisbt
base: b179bfc
Choose a base ref
...
head repository: mantisbt/mantisbt
compare: 0ec4563
Choose a head ref
  • 2 commits
  • 7 files changed
  • 1 contributor

Commits on Apr 14, 2012

  1. Improved get_status_option_list() function 

    Previous behavior to return all available values for the status enum
when the workflow is not set for the given status, could potentially
result in a security issue (letting the user bypass the workflow). The
function now returns an empty array in this case, leaving it up to the
caller to handle a possibly empty list.

Simplified and optimized the test in the foreach loop.

Do not add 'closed' status to the list if it is the current status.

Added PHPdoc function header.

Affects #11661, #14156
    @dregad
    dregad committed Apr 14, 2012
    Copy the full SHA
    0b49c6a View commit details
    Browse the repository at this point in the history

  2. Add 'Close' button for bugs 

    This commit introduces a new 'Close' button in the View Issue Details
page, making it easier and more intuitive for reporters to close their
own issues (when $g_allow_reporter_close = ON).

It also improves the access level verifications, simplifies the code and
makes it more readable by using standard access check functions.

This is an improvement over the functionality implemented in #11502 not
only in terms of usability, but also for security as in some specific
cases users could actually bypass the workflow.

Fixes #14156
    @dregad
    dregad committed Apr 14, 2012
    Copy the full SHA
    0ec4563 View commit details
    Browse the repository at this point in the history