fixed small leak in Mojo::IOLoop::Server

mojolicious · May 9, 2014 · f28eb63 · f28eb63
1 parent 21bbb91
commit f28eb63
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/lib/Mojo/IOLoop/Server.pm b/lib/Mojo/IOLoop/Server.pm
@@ -128,12 +128,17 @@ sub _accept {
 
     # Start TLS handshake
     $self->emit_safe(accept => $handle) and next unless my $tls = $self->{tls};
-    next unless $handle = IO::Socket::SSL->start_SSL($handle, %$tls);
-    $self->reactor->io($handle => sub { $self->_tls($handle) });
-    $self->{handles}{$handle} = $handle;
+    $self->_handshake($self->{handles}{$handle} = $handle)
+      if $handle = IO::Socket::SSL->start_SSL($handle, %$tls);
   }
 }
 
+sub _handshake {
+  my ($self, $handle) = @_;
+  weaken $self;
+  $self->reactor->io($handle => sub { $self->_tls($handle) });
+}
+
 sub _tls {
   my ($self, $handle) = @_;