net: register net.Server callback only once

Only register once for listening when passing a callback to Server.listen(), this prevents servers recycled using close() from invoking the callback when Server.listen() is called later.
nodejs · Oct 13, 2011 · 4b0e368 · 4b0e368
1 parent fab68aa
commit 4b0e368
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/lib/net.js b/lib/net.js
@@ -698,7 +698,7 @@ Server.prototype.listen = function() {
 
   var lastArg = arguments[arguments.length - 1];
   if (typeof lastArg == 'function') {
-    self.addListener('listening', lastArg);
+    self.once('listening', lastArg);
   }
 
   var port = toPort(arguments[0]);

diff --git a/test/simple/test-net-server-listen-remove-callback.js b/test/simple/test-net-server-listen-remove-callback.js
@@ -0,0 +1,19 @@
+var common = require('../common');
+var assert = require('assert');
+var net = require('net');
+
+// Server should only fire listen callback once
+var server = net.createServer();
+
+server.on('close', function() {
+  var listeners = server.listeners('listening');
+  console.log('Closed, listeners:', listeners.length);
+  assert.equal(0, listeners.length);
+});
+
+server.listen(3000, function() {
+  server.close();
+  server.listen(3001, function() {
+    server.close();
+  });
+});