Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: elkarte/Elkarte
base: 4d29a16764ad
Choose a base ref
...
head repository: elkarte/Elkarte
compare: 34bd7d68027b
Choose a head ref
  • 15 commits
  • 24 files changed
  • 1 contributor

Commits on Jun 21, 2013

  1. Security policy: reject magic_quotes configuration if enabled. Cleanu… 

    …p QueryString.php of magic quotes.

Signed-off-by: Norv <a.w.norv@gmail.com>
    @norv
    norv committed Jun 21, 2013
    Copy the full SHA
    9dd00ae View commit details
    Browse the repository at this point in the history

  2. Move utility functions _recursive() to Util class. They aren't curren… 

    …tly used, but potentially useful...

Signed-off-by: Norv <a.w.norv@gmail.com>
    @norv
    norv committed Jun 21, 2013
    Copy the full SHA
    c485bee View commit details
    Browse the repository at this point in the history

  3. htmlspecialchars() HTTP_USER_AGENT. (from Util.) This removes db enti… 

    …rely from QueryString.php..

Signed-off-by: Norv <a.w.norv@gmail.com>
    @norv
    norv committed Jun 21, 2013
    Copy the full SHA
    cf9adf6 View commit details
    Browse the repository at this point in the history

  4. Refactor $smcFunc['db_unescape_string'] -> $db->unescape_string() and… 

    … remove it from $smcFunc.

Signed-off-by: Norv <a.w.norv@gmail.com>
    @norv
    norv committed Jun 21, 2013
    Copy the full SHA
    f77b8bf View commit details
    Browse the repository at this point in the history

  5. Move cleanRequest() up in the execution chain. (before loading the db) 

    Signed-off-by: Norv <a.w.norv@gmail.com>
    @norv
    norv committed Jun 21, 2013
    Copy the full SHA
    7d8f18d View commit details
    Browse the repository at this point in the history

  6. Remove a custom $_SERVER['is_cli'] var 

    Signed-off-by: Norv <a.w.norv@gmail.com>
    @norv
    norv committed Jun 21, 2013
    Copy the full SHA
    7320270 View commit details
    Browse the repository at this point in the history

  7. Add Request class, for the request and its environment. It holds curr… 

    …ently client/ban ips and user agent, will hold http scheme.

cleanRequest() uses it.

Signed-off-by: Norv <a.w.norv@gmail.com>
    @norv
    norv committed Jun 21, 2013
    Copy the full SHA
    2478d9f View commit details
    Browse the repository at this point in the history

  8. Remove $_SERVER['BAN_CHECK_IP'] -> ban_ip() method of Request 

    Signed-off-by: Norv <a.w.norv@gmail.com>
    @norv
    norv committed Jun 21, 2013
    Copy the full SHA
    3123494 View commit details
    Browse the repository at this point in the history

  9. Remove the last trace of $_SERVER['BAN_CHECK_IP'] which was for compa… 

    …tibility

Signed-off-by: Norv <a.w.norv@gmail.com>
    @norv
    norv committed Jun 21, 2013
    Copy the full SHA
    24a285c View commit details
    Browse the repository at this point in the history

  10. Add parseRequest(), the method is part of request cleaning and makes … 

    …sure board, topic, and other necessary vars are ready to use.

Signed-off-by: Norv <a.w.norv@gmail.com>
    @norv
    norv committed Jun 21, 2013
    Copy the full SHA
    0583ca5 View commit details
    Browse the repository at this point in the history

  11. Add server_software() to Request, to query for the webserver. 

    Signed-off-by: Norv <a.w.norv@gmail.com>
    @norv
    norv committed Jun 21, 2013
    Copy the full SHA
    45b5524 View commit details
    Browse the repository at this point in the history

  12. Refactor $_SERVER['HTTP_USER_AGENT'] to user_agent(). 

    Signed-off-by: Norv <a.w.norv@gmail.com>
    @norv
    norv committed Jun 21, 2013
    Copy the full SHA
    437d977 View commit details
    Browse the repository at this point in the history

  13. Add scheme, https or http 

    Signed-off-by: Norv <a.w.norv@gmail.com>
    @norv
    norv committed Jun 21, 2013
    Copy the full SHA
    0a930ed View commit details
    Browse the repository at this point in the history

  14. Add Request tests. These are the first *unit* tests, they test a self… 

    …-contained

unit of behavior.
Well in the measure accepting superglobals directly and filling globals counts as self-contained. :P

Signed-off-by: Norv <a.w.norv@gmail.com>
    @norv
    norv committed Jun 21, 2013
    Copy the full SHA
    4163f02 View commit details
    Browse the repository at this point in the history

  15. Merge pull request #431 from norv/querystring.php 

    Querystring.php
    @norv
    norv committed Jun 21, 2013
    Copy the full SHA
    34bd7d6 View commit details
    Browse the repository at this point in the history