Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: b7d76a1a7ba4
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: ae6f4b32c47e
Choose a head ref
  • 2 commits
  • 8 files changed
  • 2 contributors

Commits on Jan 17, 2013

  1. child_process: do not keep list of sent sockets 

    Keeping list of all sockets that were sent to child process causes memory
leak and thus unacceptable (see #4587). However `server.close()` should
still work properly.

This commit introduces two options:

* child.send(socket, { track: true }) - will send socket and track its status.
  You should use it when you want `server.connections` to be a reliable
  number, and receive `close` event on sent sockets.
* child.send(socket) - will send socket without tracking it status. This
  performs much better, because of smaller number of RTT between master and
  child.

With both of these options `server.close()` will wait for all sent
sockets to get closed.
    @indutny @isaacs
    indutny authored and isaacs committed Jan 17, 2013
    Copy the full SHA
    db5ee0b View commit details
    Browse the repository at this point in the history

  2. benchmark: Add resume() in static_http_server

    @isaacs
    isaacs committed Jan 17, 2013
    Copy the full SHA
    ae6f4b3 View commit details
    Browse the repository at this point in the history