Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: e8a04f39199a
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 8dad99fbf772
Choose a head ref
  • 11 commits
  • 19 files changed
  • 10 contributors

Commits on Dec 11, 2014

  1. lib,src: fix spawnSync ignoring its 'env' option

    PR-URL: #8546
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    juamedgod authored and trevnorris committed Dec 11, 2014
    Copy the full SHA
    946cec7 View commit details
    Browse the repository at this point in the history
  2. test: add test for spawnSync() env option

    PR-URL: #8845
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    cjihrig authored and trevnorris committed Dec 11, 2014
    Copy the full SHA
    4bba870 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2014

  1. doc: clarify create{Read,Write}Stream fd option

    Clarify the fd option: it is preferred to the path parameter, omits
    the "open" event if given, and is available on WriteStreams as well.
    
    PR-URL: #7707
    Fixes: #7707
    Fixes: #7708
    Fixes: #4367
    Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
    benjamincburns authored and chrisdickinson committed Dec 16, 2014
    Copy the full SHA
    5b9e5bd View commit details
    Browse the repository at this point in the history
  2. zlib: support concatenated gzip files

    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    PR-URL: #6442
    eendeego authored and chrisdickinson committed Dec 16, 2014
    Copy the full SHA
    6f6a979 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2014

  1. debugger: fix unhandled error in setBreakpoint

    Fix Interface.setBreakpoint() to correctly handle an attempt to set a
    breakpoint in the current script when there is no current script.
    This usually happens when the debugged process is not paused.
    
    Fixes: #6453
    PR-URL: #6460
    Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
    bajtos authored and chrisdickinson committed Dec 17, 2014
    Copy the full SHA
    e93ff4f View commit details
    Browse the repository at this point in the history
  2. src: fix windows build error

    Fix a Windows-only build error that was introduced in
    commit 1183ba4 ("zlib: support concatenated gzip files").
    
    Rename the NO_ERROR and FAILED enumerations, they conflict
    with macros of the same name in <winerror.h>.
    
    PR-URL: #8893
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    Reviewed-By: Rod Vagg <rod@vagg.org>
    Reviewed-by: Timothy J Fontaine <tjfontaine@gmail.com>
    bnoordhuis authored and chrisdickinson committed Dec 17, 2014
    Copy the full SHA
    93533e9 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2014

  1. stream: switch _writableState.buffer to queue

    In cases where many small writes are made to a stream
    lacking _writev, the array data structure backing the
    WriteReq buffer would greatly increase GC pressure.
    
    Specifically, in the fs.WriteStream case, the
    clearBuffer routine would only clear a single WriteReq
    from the buffer before exiting, but would cause the
    entire backing array to be GC'd. Switching to [].shift
    lessened pressure, but still the bulk of the time was
    spent in memcpy.
    
    This replaces that structure with a linked list-backed
    queue so that adding and removing from the queue is O(1).
    In the _writev case, collecting the buffer requires an
    O(N) loop over the buffer, but that was already being
    performed to collect callbacks, so slowdown should be
    neglible.
    
    PR-URL: #8826
    Reviewed-by: Timothy J Fontaine <tjfontaine@gmail.com>
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    chrisdickinson committed Dec 18, 2014
    1
    Copy the full SHA
    9158666 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2014

  1. doc: add details for http res/req end callback

    Add documentation for the callback parameter of http.ClientRequest's and
    http.ServerResponse's end methods.
    
    Signed-off-by: Julien Gilli <julien.gilli@joyent.com>
    JacksonTian authored and Julien Gilli committed Dec 19, 2014
    Copy the full SHA
    890baa0 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2014

  1. url: improve parsing speed

    The url.parse() function now checks whether an escapable character is in
    the URL before trying to escape it.
    
    PR-URL: #8638
    [trev.norris@gmail.com: Switch to use continue instead of if]
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    CGavrila authored and trevnorris committed Dec 30, 2014
    Copy the full SHA
    6a03fce View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2014

  1. path: don't lower-cases drive letters

    In general path functions don't change the case of a path. Making an
    exception for windows drive letters violates the principle of least
    surprise.
    
    Changing the drive letter case has caused a lot of issues, including
    #7031, #7806 and lots of bikeshedding about
    whether uppercase is the right case or lowercase.
    
    This effectively reverts a05f973
    
    Reviewed-By: not_yet
    PR-URL: #8934
    piscisaureus authored and orangemocha committed Dec 31, 2014
    Copy the full SHA
    65ffebf View commit details
    Browse the repository at this point in the history
  2. test-require-resolve: use case insensitive compare

    The test fixtures directory is derived from the path to the currently
    running script, which is itself specified on the command line. That
    means that the case of the fixtures dir may not match what the test
    expects (when executed on a case-insensitive file system).
    
    Reviewed-By: not_yet
    PR-URL: #8934
    piscisaureus authored and orangemocha committed Dec 31, 2014
    Copy the full SHA
    8dad99f View commit details
    Browse the repository at this point in the history