Hierarchy transparent #394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -56,8 +56,11 @@ public Model createModelForResource(final FedoraResource resource, | |||
|
|
|||
| if (resource.getNode().isNodeType( | |||
| FedoraJcrTypes.FEDORA_RESOURCE)) { | |||
| if (resource.getPath(graphSubjects) == null) { | |||
| System.out.println("resource.getPath() is Null "); | |||
There was a problem hiding this comment.
A "System.out" is probably not adequate for stopping the NPE on the following lines.
|
I've corrected the codes in this PR as suggested. |
|
Okay, I've reset the trace in my last commit, updated the logging message, and removed the System.out message since exception message includes the null path information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Andrew,
As discussed during the stand up meeting this morning, I put all my codes together for you to review the working transparent hierarchy features except the getParent() implantation, which is separated and expressed in #388. This includes the transparent hierarchy support for versions and all other components in the main fcrepo4 repository.