Timeout mechanism for transactions using the spring-scheduler API #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Transaction tx = txs.next().getValue(); | ||
| if (tx.getExpires().getTime() <= System.currentTimeMillis()) { | ||
| logger.debug("timeout for transaction " + tx.getId()); | ||
| txs.remove(); |
There was a problem hiding this comment.
Should the transaction be rolled back on remove?
There was a problem hiding this comment.
At the moment there is no rollback() method on transactions since a rollback in the current semantics means just not to save the session.
It would certainly make sense to do a rollback though if there is anything to clean up
|
I added a retry method in the integration test and rollback and commit methods to the Transaction as suggested. The branch has been rebased onto master. |
|
grml i completey messed up the git history illl reopen this soon... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a REST endpoint for transaction creation/commit/rollback at "/rest/fcr:tx" and a dummy method for object creation which can be wrapped inside a tx.