refactoring manage mails. #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
|
fixed the issues, thank you for the review :) |
| list ($_GET['te']) = $smcFunc['db_fetch_row']($request); | ||
| $smcFunc['db_free_result']($request); | ||
| } | ||
| $_GET['te'] = list_getMailQueueSize(); |
There was a problem hiding this comment.
Since the $_GET['te'] is used just here and in _pauseMailQueueClear, wouldn't be better to use a variable or something instead of assign it to a $_GET?
There was a problem hiding this comment.
Yes, I think that would be better, than to use $_GET directly. Specially with encapsulation of methods, it suits its purpose better if we don't break that encapsulation by superglobals
Of course, please feel free to! Better encapsulation and separation of concerns makes it for a much nicer code to play around with ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactoring PR, purpose is to:
Please review carefully, I don't have a proper test system set up in order to test the mail queue functionality.
Note: This is just a sample, If you like it I can pick up and redisign other files too:)