Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database search and replace! #435

Merged
merged 16 commits into from May 20, 2013
Merged

Database search and replace! #435

merged 16 commits into from May 20, 2013

Conversation

emanuele45
Copy link
Contributor

This time I have the honor to break everything!! 馃懐

Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
@Spuds
Copy link
Contributor

Spuds commented May 20, 2013

馃檴 馃檳 馃檲 ... I declare Ema the winner of breaking the most stuff .... everyone else are just posers

@norv
Copy link
Contributor

norv commented May 20, 2013

LOL wow... There we go, thank you so much Ema!

norv added a commit that referenced this pull request May 20, 2013
@norv norv merged commit e95dc9b into elkarte:master May 20, 2013
@norv
Copy link
Contributor

norv commented May 20, 2013

And, it's DONE. 馃槅

@emanuele45 emanuele45 deleted the database_snr branch May 20, 2013 23:32
@emanuele45
Copy link
Contributor Author

/me runs

@norv
Copy link
Contributor

norv commented May 21, 2013

I presume the next days will be booked for rebasing and fixing. :) Luckily, the changes introduced by this PR should be practically always the same. There are no changes in parameters lists, and names are similar.

@norv
Copy link
Contributor

norv commented May 21, 2013

Just a suggestion: I would use rebase, not merge, for updating (older) branches to the current master. Merge would create yet another such big commit. And if there are conflicts, the merge will be hard for you and for us to read and review, and it could risk to revert valid changes.
On the contrary, rebase will try to apply anew one by one, your commits on the older branch, on top of the current master. That leads to a clean result, at least readable for you as well as everyone :)
A sequence I'd use is like:

git checkout master
git pull elkarte_remote master
git checkout list_old_branch
git rebase master // may have conflicts to solve
git push origin list_old_branch // if the branch has already been published, git may reject this push
git push -f origin list_old_branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants