Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: metacpan/metacpan-web
base: 406cacf9c1d0
Choose a base ref
...
head repository: metacpan/metacpan-web
compare: c2207d771729
Choose a head ref
  • 8 commits
  • 6 files changed
  • 2 contributors

Commits on Aug 10, 2013

  1. Add a test to make sure we have links

    @omega
    omega committed Aug 10, 2013
    Copy the full SHA
    6910ed0 View commit details
    Browse the repository at this point in the history

  2. Remove the old vmethod implementation

    @omega
    omega committed Aug 10, 2013
    Copy the full SHA
    359a3d7 View commit details
    Browse the repository at this point in the history

  3. Filter the change lines in the model 

    Also escape HTML there, since we need to preserve the links when we move
to the template. html filter stolen from Template::Alloy.

The design of this code isn't the pretties, but it does something for
now.
    @omega
    omega committed Aug 10, 2013
    Copy the full SHA
    15ee5cc View commit details
    Browse the repository at this point in the history

  4. We should have a number for RT links

    @omega
    omega committed Aug 10, 2013
    Copy the full SHA
    b0d000e View commit details
    Browse the repository at this point in the history

  5. Add Github linking support 

    This will most likely need refinement over time.

One idea could be to support the extended syntax that github markdown supports

* <user>/<repo>#<num> links to the bug in that repos issues
* <repo>#<num> links to the bug in same user, different repo
    @omega
    omega committed Aug 10, 2013
    Copy the full SHA
    fd7d629 View commit details
    Browse the repository at this point in the history

  6. remove Data::Dump

    @omega
    omega committed Aug 10, 2013
    Copy the full SHA
    fe46795 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2013

  1. Add tests for _gh and _rt_cpan regexes 

    The tests are maybe crude, but they document some of the patterns we match, and
allows us to add more as there will be more discovered
    @omega
    omega committed Aug 11, 2013
    Copy the full SHA
    df150d8 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2013

  1. Merge pull request #907 from omega/omega/refactor-rt-linker 

    refactor rt linker, add GH issues support
    @oalders
    oalders committed Aug 15, 2013
    Copy the full SHA
    c2207d7 View commit details
    Browse the repository at this point in the history