Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: 03bc9c6043b4
Choose a base ref
...
head repository: jruby/jruby
compare: 0dbe1b27549e
Choose a head ref
  • 3 commits
  • 4 files changed
  • 1 contributor

Commits on Mar 4, 2015

  1. CFG.toStringInstrs: Don't dump CFG of nested scopes 

    * This can be extremely distracting in debugging output.
* Users of CFG debug output that need output from nested scopes
  should explicitly do it where required.
    @subbuss
    subbuss committed Mar 4, 2015
    Copy the full SHA
    2e4c5f9 View commit details
    Browse the repository at this point in the history

  2. Build full interpreter contexts for closures on demand 

    * No need to build full ICs for closures eagerly.

* Had to add some null checks for access to ICs in a couple
  places when I experimented turning off passes on nested scopes
  (LocalOptimizationPass, AddLocalVarLoadStoreInstructionsPass).
  Keeps that code more robust and usable in different lifecycles.
    @subbuss
    subbuss committed Mar 4, 2015
    Copy the full SHA
    6a8701b View commit details
    Browse the repository at this point in the history

  3. Make LVA dependent on OptimizeDynScopesPass 

    * If LVA is to run independently on closures (without parent scopes),
  it needs info about whether dyn scopes have been eliminated or not
  (see access to IRFlags.DYNSCOPE_ELIMINATED in the code).
  So, making that dependency explicit.
    @subbuss
    subbuss committed Mar 4, 2015
    Copy the full SHA
    0dbe1b2 View commit details
    Browse the repository at this point in the history