no need for an extra line

mojolicious · Mar 3, 2015 · 77c6b1f · 77c6b1f
1 parent 270cfb3
commit 77c6b1f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/lib/Mojo/Util.pm b/lib/Mojo/Util.pm
@@ -276,8 +276,7 @@ sub tablify {
   my @spec;
   for my $row (@$rows) {
     for my $i (0 .. $#$row) {
-      $row->[$i] //= '';
-      $row->[$i] =~ s/[\r\n]//g;
+      ($row->[$i] //= '') =~ s/[\r\n]//g;
       my $len = length $row->[$i];
       $spec[$i] = $len if $len >= ($spec[$i] // 0);
     }

diff --git a/t/mojo/util.t b/t/mojo/util.t
@@ -468,8 +468,7 @@ is tablify([[undef, 'yada'], ['yada', undef]]), "      yada\nyada  \n",
   'right result';
 is tablify([['foo', 'bar', 'baz'], ['yada', 'yada', 'yada']]),
   "foo   bar   baz\nyada  yada  yada\n", 'right result';
-is tablify([['a', '', 'b'], ['c', '', 'd']]), "a    b\nc    d\n",
-  'right result';
+is tablify([['a', '', 0], [0, '', 'b']]), "a    0\n0    b\n", 'right result';
 
 # deprecated
 {