New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
java support cleanup and improvements #2624
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lass + make the related code more readable
…ch are internal also hidden JavaClass' constructor as if it's ever instantiated outside JavaSupport's class-value cache it will start to break things badly
…son typos ... `obj == NEVER` when really unwrapped value was meant to be compared
…eanup of some code
…ltiple threads) avoid warnings such as rb:42 warning: already initialized constant JavaUtilConcurrent probably related to jruby#2014
…ethod ... has a desired side effect of improving "initial" performance due not re-raising ClassNotFoundExceptions within the Ruby runtime they also will no longer be reported by the runtime with log.exeptions=true
- only pass context to (internal) getTopLevelProxyOrPackage method - setupJavaClass does not need a java_class argument (it's not used) - only intern string on addMethod (although it's likely redundat there as well)
…me up the stack ... it very likely never-ever trimmed anything
also (package) "internalized" JavaClass.getRubyArray as toRubyArray
…& also : - invoke implementation now avoids unnecessary System.arraycopy call - pre-maturily optimized some from "excessive" getRuntime() invocations
…etter readability
…k - no need to sync
…cks for singleton
… - re-arranged privates
This has been merged into test-refactor-ji and I'm continuing some refactoring there. Will merge that branch to jruby-1_7 shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
details at commits .. I'm happy to re-iterate leave some out as needed