New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker better #1366
Docker better #1366
Conversation
…nt format string, add tests
def _image_exists(self, client): | ||
def _image_exists(self, client, name=None): | ||
if name is None: | ||
name = self.image | ||
# Make sure the container exists |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[typo] image
pep8 problems. |
Travis says it's ok (yes it does). |
LGTM |
I'd appreciate at least another pair of eyes. (One build did not want to succeed). |
|
||
if not self._image_exists(docker_client): | ||
if (not self._image_exists(docker_client, image)): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benallard yes, it's a merge and here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... :magic: ...
self.volumes.append(volume) | ||
|
||
ro = False | ||
if bind.endswith(':ro'): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about :rw
that is suggested to be possible in the user guide?
(I keep "needs more review" since I want to look at it tomorrow morning with a fresh eye) |
@@ -27,90 +29,123 @@ | |||
from buildbot.buildslave import AbstractLatentBuildSlave | |||
|
|||
try: | |||
import docker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would you need this??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To address the exception by name.
EDIT: line184
Few fixes around the DockerLatentSlave