Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: PDLPorters/pdl
base: 760460ec2a9d
Choose a base ref
...
head repository: PDLPorters/pdl
compare: f0b2314426e1
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Mar 6, 2015

  1. More fixes and tests for the modulus operator. 

    Luis Mochan had reported that it was still failing for large
longlong operands. I did several things:
1) added a Q_MOD macro with internal typecasting to (long long).
2) added some tests for cases where X/N > INT_MAX
3) rewrote and extended the modulus tests so they are done for each datatype
4) added a N==0 conditional to the unsigned modulus macro, the absence of which was causing byte(5)%0 to hang.
5) changed the typecast in the MOD macro from (int) to (long); the previous version wasn't sufficient.

I have no idea what this is going to do on 32-bit machines. Have fun!
    @d-lamb
    d-lamb committed Mar 6, 2015
    Copy the full SHA
    7ebd2d5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of ssh://git.code.sf.net/p/pdl/code 

    probably somebody is going to complain about a merge commit. Sorry.
    @d-lamb
    d-lamb committed Mar 6, 2015
    Copy the full SHA
    f0b2314 View commit details
    Browse the repository at this point in the history