Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addresses FCREPO-1357 #22

Closed
wants to merge 3 commits into from
Closed

Addresses FCREPO-1357 #22

wants to merge 3 commits into from

Conversation

whikloj
Copy link
Contributor

@whikloj whikloj commented Mar 3, 2015

Did not see previous versions for indexing and oai-pmh ontologies. So stuck with owl:versionInfo for them for now.

acoburn
acoburn reviewed Mar 3, 2015
View reviewed changes
indexing.rdf
@@ -5,6 +5,11 @@
xmlns:xsd="http://www.w3.org/2001/XMLSchema#"
xmlns:dcterms="http://purl.org/dc/terms/"
xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#">
<owl:Ontology rdf:about="http://fedora.info/definitions/v4/indexing#">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include the owl namespace declaration at the top.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the owl:Ontology section mostly duplicates the following rdf:Description section -- please either remove the owl:Ontology node or the rdf:Description node, making sure that the relevant dcterms:* properties are included.

@acoburn
Copy link
Contributor

acoburn commented Mar 3, 2015

Could you please also update the rdfs2html.xsl and owl2html.xsl files to include the owl:versionInfo information (note that the rdfs2html does not at present contain any support for owl:Ontology nodes).

acoburn
acoburn reviewed Mar 3, 2015
View reviewed changes
oai-pmh.rdf
@@ -9,6 +9,7 @@
<owl:Ontology rdf:about="http://fedora.info/definitions/v4/oai-pmh#">
<rdfs:label xml:lang="en">Fedora Commons OAI-PMH Ontology</rdfs:label>
<rdfs:comment xml:lang="en">Describes relationships between Fedora Commons Repository objects used to provide an OAI-PMH service.</rdfs:comment>
<owl:versionInfo>v4/2015/02/04</owl:versionInfo>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previous version for oai-pmh is: http://fedora.info/definitions/v4/2014/11/27/oai-pmh

@acoburn
Copy link
Contributor

acoburn commented Mar 3, 2015

FYI -- the indexing# namespace was first published on 2015/02/04, so there is no previousVersion

@whikloj
Copy link
Contributor Author

whikloj commented Mar 3, 2015

It doesn't appear that the pom.xml specifies a transformationSet for the oai-pmh.rdf (nor the ldp-fedora-mapping.rdf). Should it?

@acoburn
Copy link
Contributor

acoburn commented Mar 3, 2015

There is some debate at present about the proper location for the non-repository ontologies (indexing, oai-pmh, etc). They will probably be expunged from this repo and moved into another repository. AFAIK, the ldp-fedora-mapping ontology has never been published, and probably doesn't belong there either. For now, I would suggest leaving the pom.xml as is, and saving those changes for another PR.

@ajs6f
Copy link
Contributor

ajs6f commented Mar 3, 2015

I wrote the ldp-fedora-mapping ontology, and @acoburn is definitely right-- it doesn't belong here.

@awoods
Copy link

awoods commented Mar 8, 2015

Resolved with: 9bade9e

@awoods awoods closed this Mar 8, 2015
@whikloj whikloj deleted the FCREPO-1357 branch March 8, 2015 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@whikloj @acoburn @ajs6f @awoods