Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: addccf23c464
Choose a base ref
...
head repository: jruby/jruby
compare: a90d9a8b3ccd
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on Mar 1, 2015

  1. Produce a warning on private attribute accessors 

    People seem to do that a lot after Sandi's book and not many of them
realize it actually produces a warning in CRuby.

Tried getting TestModule#test_attr out of the CRuby excluded failures,
because it was the only existing test I saw hinting of the behaviour,
however it also test that attribute names can't be a invalid
identifiers, which seems to go fine in JRuby.
    @gsamokovarov
    gsamokovarov committed Mar 1, 2015
    Copy the full SHA
    9dd446f View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2015

  1. Merge pull request #2637 from gsamokovarov/private-attrs 

    Produce a warning on private attribute accessors
    @enebo
    enebo committed Mar 3, 2015
    Copy the full SHA
    a90d9a8 View commit details
    Browse the repository at this point in the history