fix #266 and also show detail view of all values; such as arrays or l…

…ong text values for easier viewing
hawtio · May 13, 2013 · fa13cf0 · fa13cf0
1 parent a5ccd29
commit fa13cf0
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/hawtio-web/src/main/webapp/app/jmx/js/attributes.ts b/hawtio-web/src/main/webapp/app/jmx/js/attributes.ts
@@ -119,10 +119,7 @@ module Jmx {
 
     $scope.openDetailView = (entity) => {
       $scope.row = entity;
-      console.log("open detail view for key: " + entity.key);
-      var value = entity.value;
-      if (angular.isObject(value) && !angular.isArray(value)) {
-        console.log("Opening dialog");
+      if (entity.detailHtml) {
         $scope.valueDetails.open();
       }
     };
@@ -312,7 +309,10 @@ module Jmx {
         data.summary = summary;
         data.detailHtml = detailHtml;
       } else {
-        data.summary = value;
+        // TODO can we format any nicer?
+        var text = value;
+        data.summary = "" + text + "";
+        data.detailHtml = "<pre>" + text + "</pre>";
       }
     }