embed internal fixes #2630
Closed
embed internal fixes #2630
+1,433
−1,071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… impls : - share the logic of obtaining a global runtime - when global runtime is used make sure we always return the correct instance config! - introduce & use LocalContext's internal getRuntime for lazy runtime initialization - support contructors for all providers without the lazy argument
correctly synchronize local context setup/teardown (on our class)!
…ntime) initialization
…ngleton provider impl
…fields can go final
…alues on toString
…r instance config
|
rebased and commited on jruby-1_7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while using JRuby's embed APIs in a slightly more advanced scenarios I run into several issues :
BiVariableMapis not behaving as a valid Map instance (throwing NPEs on methods if not used "right")ARGVwas mean to be kept (as the map is cleared) but unfortunately not correctlyadded some tests covering intended (existing and fixed) functionality. trying to understand the details of context providers (and related embed variable impls) was a bit hard to read thus did clean-up some (helped my brain to process the code).
let me know if smt needs more work, targeting jruby-1_7 - there are no (existing) API incompatibilities ...