Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Bignum's bitwise operations #2636

Merged
merged 1 commit into from Mar 3, 2015
Merged

Fix Bignum's bitwise operations #2636

merged 1 commit into from Mar 3, 2015

Conversation

lumeet
Copy link
Contributor

@lumeet lumeet commented Mar 1, 2015

Changes are made to Bignum#&, Bignum#| and Bignum#^ to fix bitwise
operations with objects other than Bignum or Fixnum. For example:

my_bignum & Rational(3, 2) # => TypeError instead of 0

@lumeet
Fix Bignum's bitwise operations
068871b 
Changes are made to Bignum#&, Bignum#| and Bignum#^ to fix bitwise
operations with objects other than Bignum or Fixnum. For example:

  my_bignum & Rational(3, 2) # => TypeError instead of 0
enebo added a commit that referenced this pull request Mar 3, 2015
@enebo
Merge pull request #2636 from lumeet/numeric_coercion_type_error
addccf2 
Fix Bignum's bitwise operations
@enebo enebo merged commit addccf2 into jruby:master Mar 3, 2015
@enebo enebo added this to the 9.0.0.0.pre2 milestone Mar 3, 2015
@enebo enebo added the core label Mar 3, 2015
@lumeet lumeet deleted the numeric_coercion_type_error branch March 3, 2015 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
JRuby 9.0.0.0.pre2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lumeet @enebo