Fcrepo 1290 #741
Fcrepo 1290 #741
Conversation
| public void testFedoraBinaryProperties() throws RepositoryException { | ||
| final Model results = new PropertiesRdfContext(mockBinary, idTranslator).asModel(); | ||
|
|
||
| assertTrue("Response contains both NonRdfSourceDescription and RdfSourceDescription", results |
There was a problem hiding this comment.
This test looks good. Please split this assertTrue into two assertions, instead of having results.contains(...) && results.contains(...)
| node.setProperty("dc:title", "this-is-some-title"); | ||
|
|
||
| final Graph graph = | ||
| container.getChildren().next().getTriples(subjects, PropertiesRdfContext.class).asModel().getGraph(); |
There was a problem hiding this comment.
Do you want to rely on next() for this or do you want to retrieve the child by name?
There was a problem hiding this comment.
This test is to make sure if the child is a nonRdfSource with a dc:title, the request does include the child's title. I don't need to retrieve the child by name.
There was a problem hiding this comment.
I know. You're assuming that the child will be the first child of the container, and it now is, but it may or may not always be-- you're assuming that we will never change the code to add other children in some other way in between your method calls and that the JCR iteration order won't ever change. I'm not saying your test doesn't work now, I'm saying it's a bit brittle unless you specify which child to retrieve.
There was a problem hiding this comment.
I am not assuming that the child will be the first child. A parent can have multiple children and there maybe just one child with dc:title among them. I was not think of retrieve the child by name because the change I made in PropertiesRdfContext.java was Iterators...
There was a problem hiding this comment.
You are assuming that. You are only testing one child, the first one to be returned by next(). That's the "first child". If that happens not to be the binary-child you created then the test will fail even though the software may be operating correctly. It would be stronger to retrieve all the children and filter to the one that has the name you gave your binary-child, then check it for the title you think it should have. Let's leave it at that.
There was a problem hiding this comment.
Running this new test in FedoraResourceImplIT against the master branch successfully passes... therefore it does not demonstrate a fix to the issue of:
https://jira.duraspace.org/browse/FCREPO-1290
I suggest removing the updates to this class, and instead adding the integration test provided here:
https://github.com/yinlinchen/fcrepo4/pull/4
There was a problem hiding this comment.
That's interesting. It seems to imply that the problem is somewhere in whatever is producing triples from resource-children. I think that's ChildrenRdfContext?
There was a problem hiding this comment.
The test was assuming there is only one child and that's not stronger enough. I will update this test to retrieve all the children and filter to the one that has the name and check it. Thanks for the comments.
There was a problem hiding this comment.
Wait-- did you not see @awoods' comment?
There was a problem hiding this comment.
Didn't see it, but see it now.
Add integration test that demonstrates issue of:
No description provided.