Fix #13272: Hardcoded table name mantis_config_table in install.php

dregad · dregad · commit b4af23841a4b · 2011-08-29T15:13:08.000+02:00
This issue applies only to 1.2.x, as it had already been fixed in master as part of commit c8f355d
diff --git a/admin/install.php b/admin/install.php
@@ -689,7 +689,7 @@ function InsertData( $p_table, $p_data ) {
 				$t_target = $upgrade[$i][1];
 			} else if( $upgrade[$i][0] == 'UpdateFunction' ) {
 				$sqlarray = array(
-					$upgrade[$i][1],					
+					$upgrade[$i][1],
 				);
 				if( isset( $upgrade[$i][2] ) ) {
 					$sqlarray[] = $upgrade[$i][2];
@@ -740,7 +740,7 @@ function InsertData( $p_table, $p_data ) {
 		}
 		if( $f_log_queries ) {
 			# add a query to set the database version
-			echo 'INSERT INTO mantis_config_table ( value, type, access_reqd, config_id, project_id, user_id ) VALUES (\'' . $lastid . '\', 1, 90, \'database_version\', 0, 0 );' . "\r\n";
+			echo 'INSERT INTO ' . db_get_table( 'mantis_config_table' ) . ' ( value, type, access_reqd, config_id, project_id, user_id ) VALUES (\'' . $lastid . '\', 1, 90, \'database_version\', 0, 0 );' . "\r\n";
 			echo '</pre></br /><p style="color:red">Your database has not been created yet. Please create the database, then install the tables and data using the information above before proceeding.</td></tr>';
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -689,7 +689,7 @@ function InsertData( $p_table, $p_data ) {`
`689`	`689`	`$t_target = $upgrade[$i][1];`
`690`	`690`	`} else if( $upgrade[$i][0] == 'UpdateFunction' ) {`
`691`	`691`	`$sqlarray = array(`
`692`		`- $upgrade[$i][1],`
	`692`	`+ $upgrade[$i][1],`
`693`	`693`	`);`
`694`	`694`	`if( isset( $upgrade[$i][2] ) ) {`
`695`	`695`	`$sqlarray[] = $upgrade[$i][2];`
`@@ -740,7 +740,7 @@ function InsertData( $p_table, $p_data ) {`
`740`	`740`	`}`
`741`	`741`	`if( $f_log_queries ) {`
`742`	`742`	`# add a query to set the database version`
`743`		`- echo 'INSERT INTO mantis_config_table ( value, type, access_reqd, config_id, project_id, user_id ) VALUES (\'' . $lastid . '\', 1, 90, \'database_version\', 0, 0 );' . "\r\n";`
	`743`	`+ echo 'INSERT INTO ' . db_get_table( 'mantis_config_table' ) . ' ( value, type, access_reqd, config_id, project_id, user_id ) VALUES (\'' . $lastid . '\', 1, 90, \'database_version\', 0, 0 );' . "\r\n";`
`744`	`744`	`echo '</pre></br /><p style="color:red">Your database has not been created yet. Please create the database, then install the tables and data using the information above before proceeding.</td></tr>';`
`745`	`745`	`}`
`746`	`746`	`}`