Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: opal/opal
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 373702b8343a
Choose a base ref
...
head repository: opal/opal
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 8542b8eb1d29
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on Mar 6, 2015

  1. Pass "Kernel#<=> returns nil if self.==(arg) returns nil"

    @vais
    vais committed Mar 6, 2015
    Copy the full SHA
    86252b8 View commit details

  2. Merge pull request #730 from vais/kernel 

    Clean up spec/filters/bugs/kernel.rb
    @meh
    meh committed Mar 6, 2015

    Unverified

    This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
    Learn about vigilant mode
    Copy the full SHA
    8542b8e View commit details
Showing with 3 additions and 8 deletions.
  1. +3 −1 opal/corelib/kernel.rb
  2. +0 −7 spec/filters/bugs/kernel.rb
4 changes: 3 additions & 1 deletion opal/corelib/kernel.rb
View file
Original file line number Diff line number Diff line change
@@ -13,7 +13,9 @@ def ===(other)

def <=>(other)
%x{
if (#{self == other}) {
var x = #{self == other};
if (x && x !== nil) {
return 0;
}
7 changes: 0 additions & 7 deletions spec/filters/bugs/kernel.rb
View file
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
opal_filter "Kernel" do
fails "Kernel.rand returns a float if no argument is passed"
fails "Kernel.rand returns an integer for an integer argument"

fails "Kernel#<=> returns 0 if self is == to the argument"
fails "Kernel#<=> returns nil if self is eql? but not == to the argument"
fails "Kernel#<=> returns nil if self.==(arg) returns nil"

fails "Kernel#equal? returns true only if obj and other are the same object"
end