Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 627f0d27e827
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 844a0058d0c6
Choose a head ref
  • 3 commits
  • 2 files changed
  • 1 contributor

Commits on Oct 21, 2012

  1. test: add diffie-hellman regression test 

    Exercises the error path in DiffieHellman::ComputeSecret() in src/node_crypto.cc
    @bnoordhuis
    bnoordhuis committed Oct 21, 2012
    Copy the full SHA
    82df345 View commit details
    Browse the repository at this point in the history

  2. crypto: fix DH 1 byte buffer underflow 

    Passing a bad key to DiffieHellman::ComputeSecret() made it zero the byte
before the heap allocated buffer due to an erroneous size calculation.
    @bnoordhuis
    bnoordhuis committed Oct 21, 2012
    Copy the full SHA
    de18e29 View commit details
    Browse the repository at this point in the history

  3. crypto: fix DH use-after-free and memory leak 

    Fix a use-after-free bug and a memory leak in the error path of
DiffieHellman::ComputeSecret().

* the BIGNUM key was used after being freed with BN_free().
* the output buffer was not freed
    @bnoordhuis
    bnoordhuis committed Oct 21, 2012
    Copy the full SHA
    844a005 View commit details
    Browse the repository at this point in the history