First-time startup of OpenMRS via the setup wizard does not run module activators as Daemon (quick-fix) - TRUNK-3997 #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
activators as Daemon (quick-fix) - TRUNK-3997
| * @param iniCompletionJob an instance of InitializationCompletion | ||
| * @since 1.9, 1.10 | ||
| */ | ||
| public static void runInitializationCompletionJob(final InitializationCompletion iniCompletionJob) { |
There was a problem hiding this comment.
This is a security hole. The daemon should not simply run a runnable that is passed to it; rather, it should invoke a specific, hardcoded method. For example, remove the parameter in this method and call an initializationCompletion() method within the InitializationFilter.
As it stands, anyone can create a runnable by creating an instance of InitializationCompletion & overriding run, send it to this method, and run there unauthorized as super user (daemon).
Daemon should never take a runnable as a parameter and simply run whatever it is passed on a daemon thread. This creates an effective runAsSuperUser(Runnable) method that bypasses any kind of security.
RandilaP
pushed a commit
to RandilaP/openmrs-core
that referenced
this pull request
Jul 31, 2023
* Prepare offline * Fixed the version of the file size impact * Include output optimizer * Updated importmap * Updated asset optimizer * Improved documentation * Improved translation * Improved tooling w.r.t. dependent modules * Updated docs * Fixed usage of non-spa based path O3-1022 * Added offline capability button * Fixed local representation * Applied prettier * Correctly mark openmrs dev dependency * Put default webpack config in dedicated package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.