Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SF#367 BAD value parsing breakage #47

Closed
perldl-bot opened this issue Mar 2, 2015 · 0 comments
Closed

SF#367 BAD value parsing breakage #47

perldl-bot opened this issue Mar 2, 2015 · 0 comments
Labels
bug patch-exists sf-import
Milestone
PDL v2.008

Comments

@perldl-bot
Copy link

From http://sourceforge.net/p/pdl/bugs/367
@zmughal zmughal modified the milestone: PDL v2.008 Mar 2, 2015
zmughal added a commit that referenced this issue Mar 7, 2015
@zmughal
Fix for string parsing and dimension handling (fixes SF#367)
95346c8 
There was a logic error where ->setdims([]) would get called when trying
to remove the outermost dimension, but this would run after using
clump() on a string that had a single value and ->dims() == 1.

This also fixes the BAD value parsing bug in SF#367 which led to an
incorrect BAD value when parsing the string "[BAD]".
See <http://sourceforge.net/p/pdl/bugs/367/>,
<#47>.
@zmughal zmughal mentioned this issue Mar 7, 2015
Merged
zmughal added a commit that referenced this issue Mar 7, 2015
@zmughal
Fix for string parsing and dimension handling (fixes SF#367)
9585de3 
There was a logic error where ->setdims([]) would get called when trying
to remove the outermost dimension, but this would run after using
clump() on a string that had a single value and ->dims() == 1.

This also fixes the BAD value parsing bug in SF#367 which led to an
incorrect BAD value when parsing the string "[BAD]".
See <http://sourceforge.net/p/pdl/bugs/367/>,
<#47>.
@zmughal zmughal closed this as completed Mar 8, 2015
@zmughal zmughal added sf:closed and removed sf:open labels Mar 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug patch-exists sf-import
Projects
None yet
Milestone
PDL v2.008
Development

No branches or pull requests
2 participants
@zmughal @perldl-bot