Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct flag for single or double. #127

Closed
wants to merge 1 commit into from
Closed

Correct flag for single or double. #127

wants to merge 1 commit into from

Conversation

johnmay
Copy link
Member

@johnmay johnmay commented Mar 5, 2015

No description provided.

@egonw
Copy link
Member

egonw commented Mar 30, 2015

This causes regressions on my machine:

Failed tests:
CDKAtomTypeMatcherTest.testPyridine_SingleOrDouble:2314->AbstractAtomTypeTest.assertAtomTypes:68->AbstractAtomTypeTest.assertAtomType:140 Incorrect perception for atom 0 expected:<[C.sp2]> but was:<[X]>
CDKAtomTypeMatcherTest.testPyrrole_SingleOrDouble:2217->AbstractAtomTypeTest.assertAtomTypes:68->AbstractAtomTypeTest.assertAtomType:140 Incorrect perception for atom 0 expected:<[C.sp2]> but was:<[X]>
CDKAtomTypeMatcherTest.testBenzene_SingleOrDouble:2196->AbstractAtomTypeTest.assertAtomTypes:68->AbstractAtomTypeTest.assertAtomType:140 Incorrect perception for atom 0 expected:<[C.sp2]> but was:<[X]>

@johnmay
Copy link
Member Author

johnmay commented Mar 30, 2015

Okay will look into it tonight... I'm guessing there was an absolute value specified somewhere.

@egonw
Copy link
Member

egonw commented Mar 30, 2015

Yeah, I think so too... I have some deadlines to finish today, and did not have time to explore myself yet, I'm afraid...

@johnmay
Copy link
Member Author

johnmay commented Mar 30, 2015

Double checked and all okay. You need to do a clean install since static variables are inlined by the compiler.

@egonw
Copy link
Member

egonw commented Mar 30, 2015

Ugh... making it so... hang on...

@egonw
Copy link
Member

egonw commented Mar 31, 2015

... hang on ... :)

@egonw
Copy link
Member

egonw commented Mar 31, 2015

Confirmed OK, applied and pushed.

@egonw egonw closed this Mar 31, 2015
@johnmay johnmay deleted the single_or_double_flag branch September 6, 2015 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johnmay @egonw