Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Truffle] Bulk untagging passing specs #2649

Merged
merged 1 commit into from Mar 5, 2015

Conversation

bjfish
Copy link
Contributor

@bjfish bjfish commented Mar 5, 2015

No description provided.

@chrisseaton
Copy link
Contributor

Wow. Did you say you wrote a script to help do this without the problem of things hanging?

I'll just let the tests run and then merge.

@bjfish
Copy link
Contributor Author

bjfish commented Mar 5, 2015

@chrisseaton yes, the script works well for things hanging because of the time outs it has.

But it still has the problem of untagging specs that don't pass when the whole suite is run. I suspect there is some test pollution between tests when they are all run.

Here's a script that just runs each core directory with a 90 second time out (probably more useful in hindsight):
https://gist.github.com/bjfish/75d144f88c5870053fc2

Here's a link to the script that does jt untag, jt test, git checkout for each spec (about 4 hours):
https://gist.github.com/bjfish/eafa28b6bc82eb2299a3

@chrisseaton
Copy link
Contributor

The difficulty is that our system uses lots and lots of hidden state for optimisations. So running one test before another can change the state of some method which causes it to break, where it wouldn't have it if you hadn't run the other test. We're going to tackle this with some code for randomising some of that state.

chrisseaton added a commit that referenced this pull request Mar 5, 2015
[Truffle] Bulk untagging passing specs
@chrisseaton chrisseaton merged commit 76d6772 into jruby:master Mar 5, 2015
@chrisseaton chrisseaton modified the milestone: truffle-dev May 4, 2015
@enebo enebo added this to the Non-Release milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants