zlib: Fix invalidly failing test

nodejs · Nov 18, 2011 · 975f193 · 975f193
1 parent f004d5a
commit 975f193
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/test/simple/test-zlib-from-string.js b/test/simple/test-zlib-from-string.js
@@ -34,7 +34,16 @@ zlib.deflate(inputString, function(err, buffer) {
 });
 
 zlib.gzip(inputString, function(err, buffer) {
-  assert.equal(buffer.toString('base64'), expectedBase64Gzip, 'gzip encoded string should match');
+  // Can't actually guarantee that we'll get exactly the same
+  // deflated bytes when we compress a string, since the header
+  // depends on stuff other than the input string itself.
+  // However, decrypting it should definitely yield the same
+  // result that we're expecting, and this should match what we get
+  // from inflating the known valid deflate data.
+  zlib.gunzip(buffer, function (err, gunzipped) {
+    assert.equal(gunzipped.toString(), inputString,
+                 'Should get original string after gzip/gunzip');
+  });
 });
 
 var buffer = new Buffer(expectedBase64Deflate, 'base64');