Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: e42c4a38fddd
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 4b69dcb9610c
Choose a head ref
  • 12 commits
  • 16 files changed
  • 8 contributors

Commits on Feb 17, 2015

  1. fs: properly handle fd passed to truncate()

    Currently, fs.truncate() silently fails when a file descriptor
    is passed as the first argument. This commit changes this
    behavior to properly call fs.ftruncate().
    
    PR-URL: #9161
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>
    bjouhier authored and cjihrig committed Feb 17, 2015
    Copy the full SHA
    b3aa876 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2015

  1. console: allow Object.prototype fields as labels

    This is a backport of 6c3647c from
    v0.12 to v0.10.
    
    Console.prototype.timeEnd() returns NaN if the timer label
    corresponds to a property on Object.prototype. In v0.12, this was fixed
    by using Object.create(null) to construct the _times object
    
    However, the version of V8 in the v0.10 branch makes this fix not work
    as expected. In v0.10, this commit changes the _times object into a
    array of objects of the form:
    
    { label: someLabel, time: staringWallClockTime }
    
    someLabel can thus be any string, including any string that represents
    any Object.prototype field.
    
    Fixes #9116.
    
    PR: #9215
    PR-URL: #9215
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Julien Gilli committed Feb 18, 2015
    Copy the full SHA
    c8239c0 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2015

  1. net: unref timer in parent sockets

    `TLSSocket` wraps the original `net.Socket`, but writes/reads to/from
    `TLSSocket` do not touch the timers of original `net.Socket`.
    
    Introduce `socket._parent` property, and iterate through all parents
    to unref timers and prevent timeout event on original `net.Socket`.
    
    Fix: #9242
    PR-URL: nodejs/node#891
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    indutny authored and trevnorris committed Feb 19, 2015
    Copy the full SHA
    bada87b View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2015

  1. smalloc: extend user API

    node::Environment isn't accessible to user APIs, so extend smalloc to
    also accept v8::Isolate.
    
    Fixes: 75adde0 "src: remove `node_isolate` from source"
    PR-URL: nodejs/node#905
    Reviewed-by: Fedor Indutny <fedor@indutny.com>
    trevnorris committed Feb 20, 2015
    Copy the full SHA
    9deade4 View commit details
    Browse the repository at this point in the history
  2. deps: backport a02d97e from v8 upstream

    Original commit message:
    
      Fix --max_old_space_size=4096 integer overflow.
    
      BUG=v8:3857
      LOG=N
    
      Review URL: https://codereview.chromium.org/897543002
    
      Cr-Commit-Position: refs/heads/master@{#26510}
    
    PR-URL: #9200
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
    bsnote authored and trevnorris committed Feb 20, 2015
    Copy the full SHA
    2fc5eeb View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2015

  1. doc: remove broken link to tracing api

    closes nodejs/nodejs.org-archive#77
    
    PR: #9172
    PR-URL: #9172
    Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
    robertkowalski authored and Julien Gilli committed Feb 24, 2015
    Copy the full SHA
    08a1192 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2015

  1. doc: fix default value of opts.decodeURIComponent

    In the documentation for querystring.parse, the documentation mentions
    that the default value for options.decodeURIComponent is the
    decodeURIComponent function, but it's actually the querystring.unescape
    function.
    
    PR-URL: #9259
    Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
    h7lin authored and Julien Gilli committed Feb 25, 2015
    Copy the full SHA
    f1bf883 View commit details
    Browse the repository at this point in the history
  2. doc: add explanations for querystring

     - add an article: `decode a non-utf8 string`
     - explain default and fallback behaviour of `querystring.unescape`
    
    PR-URL: #9259
    Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
    robertkowalski authored and Julien Gilli committed Feb 25, 2015
    Copy the full SHA
    5d821fe View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2015

  1. test: make destroyed-socket-write2.js more robust

    test/simple/test-http-destroyed-socket-write2.js validates
    that you get an appropriate error when trying to write to
    a request when the response on the other side has been destroyed.
    
    The test uses http.request to get a request and then keeps writing
    to it until either it hits 128 writes or gets the expected error.
    Since the writes are asynchronous we see that the writes just end
    up adding events to the event loop, which then later get processed
    once the connection supporting the request is fully ready.
    
    The test is timing dependent and if takes too long for the connection
    to be made the limit of 128 writes is exceeded and the test fails.
    The fact that the test allows a number of writes is probably to allow
    some delay for the connection to be ready for writing.
    
    On AIX, in the default configuration using the loopback interface
    is slower and the test fails because the delay is such that many
    more writes can be queued up before the connection takes place.
    If we use the host ip instead of defaulting to the loopback then
    the test passes.
    
    The test needs to be made more robust to delays. Since each write
    simply enqueues an additional write to the event queue there is
    probably no point in doing the second write until the first has
    completed. This patch schedules the next write when the first one
    completes and allows the test to pass even if it takes longer for
    the connection to be ready for writing
    
    PR-URL: #9270
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>
    mhdawson authored and cjihrig committed Feb 27, 2015
    Copy the full SHA
    3e40e12 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2015

  1. src: fix builtin modules failing with --use-strict

    Currently, lib/_tls_legacy.js and lib/crypto.js cannot be loaded when
    --use-strict is passed to node. In addition to that, console.trace
    throws because it uses arguments.callee.
    
    This change fixes these issues and adds a test that makes sure
    every external built-in module can be loaded with require when
    --use-strict is enabled.
    
    Please note that this change does not fix all issues with built-in
    modules' code running with --use-strict. It is very likely that some
    code in the built-in modules still fails when passing this flag.
    
    However, fixing all code would require us to enable strict mode by
    default in all builtins modules, which would certainly break existing
    applications.
    
    Fixes #9187.
    
    PR: #9237
    PR-URL: #9237
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    Julien Gilli committed Feb 28, 2015
    Copy the full SHA
    b233131 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'upstream/v0.10' into v0.12

    Conflicts:
    	lib/console.js
    	test/simple/test-console.js
    Julien Gilli committed Feb 28, 2015
    Copy the full SHA
    e82e86b View commit details
    Browse the repository at this point in the history
  3. Merge remote-tracking branch 'upstream/v0.12'

    Julien Gilli committed Feb 28, 2015
    Copy the full SHA
    4b69dcb View commit details
    Browse the repository at this point in the history