Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 7eaeddb93cd3
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 6f939ded1dd6
Choose a head ref
  • 18 commits
  • 58 files changed
  • 8 contributors

Commits on Aug 7, 2014

  1. 8
    Copy the full SHA
    92598e8 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    912b5e0 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2014

  1. Copy the full SHA
    7c04197 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2014

  1. net: remove use of arguments in Server constructor

    The current implementation uses the arguments object in the Server()
    constructor. Since both arguments to Server() are optional, there was a
    high likelihood of accessing a non-existent element in arguments, which
    carries a performance overhead. This commit replaces the arguments
    object with named arguments.
    
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    cjihrig authored and trevnorris committed Oct 1, 2014
    Copy the full SHA
    25702ab View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2014

  1. stream: remove duplicated expression

    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
    yorkie authored and chrisdickinson committed Oct 9, 2014
    Copy the full SHA
    cfcb1de View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2015

  1. Merge remote-tracking branch 'upstream/v0.12'

    Conflicts:
    	src/node_version.h
    tjfontaine committed Jan 16, 2015
    Copy the full SHA
    885f721 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2015

  1. README: fix link text

    Extends a hyperlink to cover the whole line
    
    PR-URL: #8972
    Reviewed-by: Colin Ihrig <cjihrig@gmail.com>
    Frank Cash authored and geek committed Jan 19, 2015
    2
    Copy the full SHA
    31d4847 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2015

  1. Merge remote-tracking branch 'upstream/v0.12'

    Conflicts:
    	src/node_version.h
    Julien Gilli committed Jan 30, 2015
    Copy the full SHA
    d8baf8a View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2015

  1. Merge remote-tracking branch 'upstream/v0.12'

    Conflicts:
    	src/node_version.h
    Julien Gilli committed Feb 17, 2015
    Copy the full SHA
    3917596 View commit details
    Browse the repository at this point in the history
  2. src: update AUTHORS after merge of v0.12 in master

    Julien Gilli committed Feb 17, 2015
    Copy the full SHA
    b3fcc24 View commit details
    Browse the repository at this point in the history
  3. fs: properly handle fd passed to truncate()

    Currently, fs.truncate() silently fails when a file descriptor
    is passed as the first argument. This commit changes this
    behavior to properly call fs.ftruncate(). This commit also
    adds proper type checking to the callback provided to
    makeCallback().
    
    PR-URL: #9161
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>
    bjouhier authored and cjihrig committed Feb 17, 2015
    Copy the full SHA
    4c31cda View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2015

  1. dgram: implicit binds should be exclusive

    Server sockets should be shared by default, and client sockets should be
    exclusive by default. For net/TCP, this is how it is, for dgram/UDP, its
    a little less clear what a client socket is, but a socket that is
    auto-bound during a dgram.send() is not usefully shared among cluster
    workers, any more than an outgoing TCP connection would be usefully
    shared.
    
    Since implicit binds become exclusive, implicit/client dgram sockets can
    now be used with cluster on Windows. Before, neither explicit nor
    implicitly bound sockets could be used, causing dgram to be completely
    unsupported with cluster on Windows. After this change, they become half
    supported.
    
    PR: #8643
    Reviewed-by: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-by: Bert Belder <bertbelder@gmail.com>
    Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
    sam-github authored and Julien Gilli committed Feb 18, 2015
    Copy the full SHA
    e42c4a3 View commit details
    Browse the repository at this point in the history
  2. console: allow Object.prototype fields as labels

    This is a backport of 6c3647c from
    v0.12 to v0.10.
    
    Console.prototype.timeEnd() returns NaN if the timer label
    corresponds to a property on Object.prototype. In v0.12, this was fixed
    by using Object.create(null) to construct the _times object
    
    However, the version of V8 in the v0.10 branch makes this fix not work
    as expected. In v0.10, this commit changes the _times object into a
    array of objects of the form:
    
    { label: someLabel, time: staringWallClockTime }
    
    someLabel can thus be any string, including any string that represents
    any Object.prototype field.
    
    Fixes #9116.
    
    PR: #9215
    PR-URL: #9215
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Julien Gilli committed Feb 18, 2015
    Copy the full SHA
    c8239c0 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2015

  1. test: make destroyed-socket-write2.js more robust

    test/simple/test-http-destroyed-socket-write2.js validates
    that you get an appropriate error when trying to write to
    a request when the response on the other side has been destroyed.
    
    The test uses http.request to get a request and then keeps writing
    to it until either it hits 128 writes or gets the expected error.
    Since the writes are asynchronous we see that the writes just end
    up adding events to the event loop, which then later get processed
    once the connection supporting the request is fully ready.
    
    The test is timing dependent and if takes too long for the connection
    to be made the limit of 128 writes is exceeded and the test fails.
    The fact that the test allows a number of writes is probably to allow
    some delay for the connection to be ready for writing.
    
    On AIX, in the default configuration using the loopback interface
    is slower and the test fails because the delay is such that many
    more writes can be queued up before the connection takes place.
    If we use the host ip instead of defaulting to the loopback then
    the test passes.
    
    The test needs to be made more robust to delays. Since each write
    simply enqueues an additional write to the event queue there is
    probably no point in doing the second write until the first has
    completed. This patch schedules the next write when the first one
    completes and allows the test to pass even if it takes longer for
    the connection to be ready for writing
    
    PR-URL: #9270
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>
    mhdawson authored and cjihrig committed Feb 27, 2015
    Copy the full SHA
    3e40e12 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2015

  1. src: fix builtin modules failing with --use-strict

    Currently, lib/_tls_legacy.js and lib/crypto.js cannot be loaded when
    --use-strict is passed to node. In addition to that, console.trace
    throws because it uses arguments.callee.
    
    This change fixes these issues and adds a test that makes sure
    every external built-in module can be loaded with require when
    --use-strict is enabled.
    
    Please note that this change does not fix all issues with built-in
    modules' code running with --use-strict. It is very likely that some
    code in the built-in modules still fails when passing this flag.
    
    However, fixing all code would require us to enable strict mode by
    default in all builtins modules, which would certainly break existing
    applications.
    
    Fixes #9187.
    
    PR: #9237
    PR-URL: #9237
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    Julien Gilli committed Feb 28, 2015
    Copy the full SHA
    b233131 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'upstream/v0.10' into v0.12

    Conflicts:
    	lib/console.js
    	test/simple/test-console.js
    Julien Gilli committed Feb 28, 2015
    Copy the full SHA
    e82e86b View commit details
    Browse the repository at this point in the history
  3. Merge remote-tracking branch 'upstream/v0.12'

    Julien Gilli committed Feb 28, 2015
    Copy the full SHA
    4b69dcb View commit details
    Browse the repository at this point in the history
  4. src: enable strict mode in all builtin modules

    This is a follow-up commit for b233131.
    
    It enables strict mode in all built-in modules.
    Julien Gilli committed Feb 28, 2015
    Copy the full SHA
    6f939de View commit details
    Browse the repository at this point in the history