Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 3c0f28ed0713
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 3c830c884759
Choose a head ref
  • 7 commits
  • 306 files changed
  • 5 contributors

Commits on Mar 3, 2015

  1. tests: fix race in test-http-curl-chunk-problem

    This test setups two event listeners: one on a child process' exit event
    , another for the same child process' stdandard output's 'data' event.
    The data even listener writes to a stream, and the exit event listener
    ends it.
    
    Because the exit event can be emitted before the data event, there is a
    chance that something will be written to the stream after it's ended,
    and that an error is thrown.
    
    This change makes the test end the stream in the listener for the child
    process' standard output's end event, which is guaranteed to be emitted
    after the last data event, thus avoiding the race.
    
    PR: #9301
    PR-URL: #9301
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: James M Snell <jasnell@users.noreply.github.com>
    Reviewed-By: Bert Belder <bertbelder@gmail.com>
    Julien Gilli committed Mar 3, 2015
    Copy the full SHA
    d9a309f View commit details
    Browse the repository at this point in the history
  2. deps: upgrade npm to 2.6.1

    PR: #9297
    PR-URL: #9297
    Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    othiym23 authored and Julien Gilli committed Mar 3, 2015
    Copy the full SHA
    63fbd10 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2015

  1. Copy the full SHA
    cc237ea View commit details
    Browse the repository at this point in the history
  2. build: fix use of strict aliasing

    The -fno-strict-aliasing flag was added to fix compilation warnings when
    building Node.js with GCC <= 4.4
    trevnorris committed Mar 4, 2015
    Copy the full SHA
    dbde261 View commit details
    Browse the repository at this point in the history
  3. lib: fix stdio/ipc sync i/o regression

    process.send() should be synchronous, it should block until the message
    has been sent in full, but it wasn't after the second-to-last libuv
    upgrade because of commit libuv/libuv@393c1c5 ("unix: set non-block
    mode in uv_{pipe,tcp,udp}_open"), which made its way into io.js in
    commit 07bd05b ("deps: update libuv to 1.2.1").
    
    Commit libuv/libuv@b36d4ff ("unix: implement uv_stream_set_blocking()")
    as landed in io.js in commit 9681fca ("deps: update libuv to 1.4.0")
    makes it possible to restore the synchronous behavior again and that's
    precisely what this commit does.
    
    The same line of reasoning applies to `net.Socket({ fd: 1 })`: creating
    a socket object from a stdio file descriptor, like the `process.stdout`
    getter does, should put the file descriptor in blocking mode for
    compatibility reasons.
    
    PR-URL: nodejs/node#774
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    bnoordhuis authored and trevnorris committed Mar 4, 2015
    Copy the full SHA
    3b713b7 View commit details
    Browse the repository at this point in the history
  4. uv: float win pipe patch

    Float patch to fix pipe on Windows. Original commit message:
    
      win: fix pipe blocking writes
    
      In the code path for pipe blocking writes, WriteFile is already
      posting a completion packet to the I/O completion port.
      POST_COMPLETION_FOR_REQ was causing the same request to get
      returned twice by GetCompletionStatusEx.
      Also on the same code path, we were waiting on the wrong event.
    
      We need to update queued_bytes and write_queue_size when a
      blocking write request completes asynchronously.
    
    Ref: libuv/libuv#238
    orangemocha authored and trevnorris committed Mar 4, 2015
    Copy the full SHA
    afcaea7 View commit details
    Browse the repository at this point in the history
  5. deps: fix libuv build on SmartOS

    Julien Gilli authored and trevnorris committed Mar 4, 2015
    Copy the full SHA
    3c830c8 View commit details
    Browse the repository at this point in the history