New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SF#368 PDL::Slatec::polyfit ignores incorrect length of weight piddle; passes garbage to slatec polfit #48
Comments
Possible fix: $w .= $y->zeros + $w; I'll put together a test. |
This reproduces the case where sending a weight vector ($w) that does not match the length of the data to fit ($x, $y) causes garbage to be sent to the underlying Slatec polfit() function. See <https://sourceforge.net/p/pdl/bugs/368/>, <#48> for more information.
This addresses the issue <https://sourceforge.net/p/pdl/bugs/368/>, <#48>.
This addresses the issue <https://sourceforge.net/p/pdl/bugs/368/>, <#48>.
I created a test out of this bug in the branch I can reproduce the problem that this non-deterministically fails under Travis-CI job #68 https://travis-ci.org/PDLPorters/pdl/builds/53132579. I have marked the I have a possible fix which is currently being tested on the same branch. |
This addresses the issue <https://sourceforge.net/p/pdl/bugs/368/>, <#48>.
This addresses the issue <https://sourceforge.net/p/pdl/bugs/368/>, <#48>.
This reproduces the case where sending a weight vector ($w) that does not match the length of the data to fit ($x, $y) causes garbage to be sent to the underlying Slatec polfit() function. See <https://sourceforge.net/p/pdl/bugs/368/>, <#48> for more information.
This addresses the issue <https://sourceforge.net/p/pdl/bugs/368/>, <#48>.
…them from TODO tests to regular tests This addresses the issue <https://sourceforge.net/p/pdl/bugs/368/>, <#48>.
A change I'm just making, to throw an error when broadcasting higher dims over a fewer-dim output, has caught the test made for this; line 23 of the The reason specifically that @djerius was having a problem originally is that until approximately today, a length-1 dim was getting quietly "inflated" (as I'm calling it, when a size-1 dim gets expanded), even on a That change has also broken PDL::FFTW3 and PDL::CCS which were supplying insufficiently-sized blocks of |
From http://sourceforge.net/p/pdl/bugs/368
The text was updated successfully, but these errors were encountered: