[Truffle] Implemented String#each_byte.

jruby · Mar 2, 2015 · e0eba28 · e0eba28
1 parent 0623029
commit e0eba28
Show file tree

Hide file tree

Showing 2 changed files with 41 additions and 3 deletions.
diff --git a/spec/truffle/tags/core/string/each_byte_tags.txt b/spec/truffle/tags/core/string/each_byte_tags.txt
@@ -1,4 +1 @@
-fails:String#each_byte passes each byte in self to the given block
 fails:String#each_byte keeps iterating from the old position (to new string end) when self changes
-fails:String#each_byte returns self
-fails:String#each_byte returns an enumerator when no block given
diff --git a/truffle/src/main/java/org/jruby/truffle/nodes/core/StringNodes.java b/truffle/src/main/java/org/jruby/truffle/nodes/core/StringNodes.java
@@ -852,6 +852,47 @@ public RubyBasicObject downcase(RubyString string) {
         }
     }
 
+    @CoreMethod(names = "each_byte", needsBlock = true)
+    public abstract static class EachByteNode extends YieldingCoreMethodNode {
+
+        @Child private CallDispatchHeadNode toEnumNode;
+
+        public EachByteNode(RubyContext context, SourceSection sourceSection) {
+            super(context, sourceSection);
+        }
+
+        public EachByteNode(EachByteNode prev) {
+            super(prev);
+        }
+
+        @Specialization
+        public Object eachByte(VirtualFrame frame, RubyString string, @SuppressWarnings("unused") UndefinedPlaceholder block) {
+            notDesignedForCompilation();
+
+            if (toEnumNode == null) {
+                CompilerDirectives.transferToInterpreter();
+                toEnumNode = insert(DispatchHeadNodeFactory.createMethodCall(getContext()));
+            }
+
+            return toEnumNode.call(frame, string, "to_enum", null, getContext().newSymbol("each_byte"));
+        }
+
+        @Specialization
+        public RubyString eachByte(VirtualFrame frame, RubyString string, RubyProc block) {
+            notDesignedForCompilation();
+
+            final ByteList bytes = string.getBytes();
+            final int begin = bytes.getBegin();
+
+            for (int i = 0; i < bytes.getRealSize(); i++) {
+                yield(frame, block, bytes.get(begin + i));
+            }
+
+            return string;
+        }
+
+    }
+
     @CoreMethod(names = "each_char", needsBlock = true)
     public abstract static class EachCharNode extends YieldingCoreMethodNode {